Page MenuHomePhabricator
Differential D10214

[identity] Implement attribute conversions for Device row
ClosedPublic
Actions

Authored by bartek on Dec 7 2023, 12:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 2:30 AM
Unknown Object (File)
Wed, Mar 12, 3:37 AM
Unknown Object (File)
Feb 20 2025, 10:56 PM
Unknown Object (File)
Feb 7 2025, 5:52 AM
Unknown Object (File)
Feb 2 2025, 9:13 PM
Unknown Object (File)
Feb 1 2025, 4:39 PM
Unknown Object (File)
Feb 1 2025, 2:58 PM
Unknown Object (File)
Feb 1 2025, 2:58 PM
View All 88 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
Commits
rCOMM44607df0dff5: [identity] Implement attribute conversions for Device row
Summary

Added From traits to convert DeviceRow from/into AttributeValues. Copied this pattern from other services - it's very handy

Depends on D10213

Test Plan

Tested later in the stack. TODO: Add unit tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
188 lines
22 lines

Diff 35268

View Options

services/identity/src/database/device_list.rs

Show All 13 Linesimport {
useSearchMessages as useSearchMessagesAction, useSearchMessages as useSearchMessagesAction,
} from '../actions/message-actions.js'; } from '../actions/message-actions.js';
import { import {
searchUsers, searchUsers,
searchUsersActionTypes, searchUsersActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js'; import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import genesis from '../facts/genesis.js'; import genesis from '../facts/genesis.js';
import { useIdentitySearch } from '../identity-search/identity-search-context.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
MessageListData, MessageListData,
} from '../selectors/chat-selectors.js'; } from '../selectors/chat-selectors.js';
import { useUserSearchIndex } from '../selectors/nav-selectors.js'; import { useUserSearchIndex } from '../selectors/nav-selectors.js';
import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js'; import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';
import type { User } from '../types/identity-search/search-response-types.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js'; import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js'; import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import type { import type {
AccountUserInfo, AccountUserInfo,
GlobalAccountUserInfo, GlobalAccountUserInfo,
▲ Show 20 Lines • Show All 328 Lines • ▼ Show 20 Lines void (async () => {
setUsernameToSearch(lowercaseText); setUsernameToSearch(lowercaseText);
} }
})(); })();
}, [ensCache, lowercaseText]); }, [ensCache, lowercaseText]);
return usernameToSearch; return usernameToSearch;
} }
function useSearchIdentityUsers(
usernameInputText: string,
): $ReadOnlyArray<User> {
const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,
);
const { sendPrefixQuery } = useIdentitySearch();
const [searchResults, setSearchResults] = React.useState(
ashoatUnsubmitted
Not Done
Inline Actions

Same comment here... please move the typehint

ashoat: Same comment here... please move the typehint
ashoatUnsubmitted
Not Done
Inline Actions

Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here.

In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid.

Okay to skip it this time I guess

ashoat: Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping…
willAuthorUnsubmitted
Done
Inline Actions

Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward.

will: Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback…
([]: $ReadOnlyArray<User>),
);
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
React.useEffect(() => {
if (forwardLookupSearchText.length === 0) {
setSearchResults([]);
return;
}
void (async () => {
try {
const result = await sendPrefixQuery(forwardLookupSearchText);
setSearchResults(
result.filter(({ userID }) => userID !== currentUserID),
);
} catch (err) {
console.error(err);
setSearchResults([]);
}
})();
}, [currentUserID, forwardLookupSearchText, sendPrefixQuery]);
return searchResults;
}
function useSearchUsers( function useSearchUsers(
usernameInputText: string, usernameInputText: string,
): $ReadOnlyArray<GlobalAccountUserInfo> { ): $ReadOnlyArray<GlobalAccountUserInfo> {
const currentUserID = useSelector( const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText); const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines): ?(ChatMessageInfoItem[]) {
return sortedChatMessageInfoItems; return sortedChatMessageInfoItems;
} }
export { export {
usePotentialMemberItems, usePotentialMemberItems,
notFriendNotice, notFriendNotice,
useSearchMessages, useSearchMessages,
useSearchUsers, useSearchUsers,
useSearchIdentityUsers,
filterChatMessageInfosForSearch, filterChatMessageInfosForSearch,
useForwardLookupSearchText, useForwardLookupSearchText,
}; };
View Options

services/identity/src/ddb_utils.rs

Show All 13 Linesimport {
useSearchMessages as useSearchMessagesAction, useSearchMessages as useSearchMessagesAction,
} from '../actions/message-actions.js'; } from '../actions/message-actions.js';
import { import {
searchUsers, searchUsers,
searchUsersActionTypes, searchUsersActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js'; import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import genesis from '../facts/genesis.js'; import genesis from '../facts/genesis.js';
import { useIdentitySearch } from '../identity-search/identity-search-context.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
MessageListData, MessageListData,
} from '../selectors/chat-selectors.js'; } from '../selectors/chat-selectors.js';
import { useUserSearchIndex } from '../selectors/nav-selectors.js'; import { useUserSearchIndex } from '../selectors/nav-selectors.js';
import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js'; import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';
import type { User } from '../types/identity-search/search-response-types.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js'; import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js'; import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import type { import type {
AccountUserInfo, AccountUserInfo,
GlobalAccountUserInfo, GlobalAccountUserInfo,
▲ Show 20 Lines • Show All 328 Lines • ▼ Show 20 Lines void (async () => {
setUsernameToSearch(lowercaseText); setUsernameToSearch(lowercaseText);
} }
})(); })();
}, [ensCache, lowercaseText]); }, [ensCache, lowercaseText]);
return usernameToSearch; return usernameToSearch;
} }
function useSearchIdentityUsers(
usernameInputText: string,
): $ReadOnlyArray<User> {
const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,
);
const { sendPrefixQuery } = useIdentitySearch();
const [searchResults, setSearchResults] = React.useState(
ashoatUnsubmitted
Not Done
Inline Actions

Same comment here... please move the typehint

ashoat: Same comment here... please move the typehint
ashoatUnsubmitted
Not Done
Inline Actions

Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here.

In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid.

Okay to skip it this time I guess

ashoat: Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping…
willAuthorUnsubmitted
Done
Inline Actions

Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward.

will: Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback…
([]: $ReadOnlyArray<User>),
);
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
React.useEffect(() => {
if (forwardLookupSearchText.length === 0) {
setSearchResults([]);
return;
}
void (async () => {
try {
const result = await sendPrefixQuery(forwardLookupSearchText);
setSearchResults(
result.filter(({ userID }) => userID !== currentUserID),
);
} catch (err) {
console.error(err);
setSearchResults([]);
}
})();
}, [currentUserID, forwardLookupSearchText, sendPrefixQuery]);
return searchResults;
}
function useSearchUsers( function useSearchUsers(
usernameInputText: string, usernameInputText: string,
): $ReadOnlyArray<GlobalAccountUserInfo> { ): $ReadOnlyArray<GlobalAccountUserInfo> {
const currentUserID = useSelector( const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText); const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines): ?(ChatMessageInfoItem[]) {
return sortedChatMessageInfoItems; return sortedChatMessageInfoItems;
} }
export { export {
usePotentialMemberItems, usePotentialMemberItems,
notFriendNotice, notFriendNotice,
useSearchMessages, useSearchMessages,
useSearchUsers, useSearchUsers,
useSearchIdentityUsers,
filterChatMessageInfosForSearch, filterChatMessageInfosForSearch,
useForwardLookupSearchText, useForwardLookupSearchText,
}; };