Page MenuHomePhabricator

[commtest] Add functions to login/logout existing username
ClosedPublic

Authored by bartek on Dec 21 2023, 2:12 AM.
Tags
None
Referenced Files
F2153594: D10421.id34895.diff
Sun, Jun 30, 5:30 PM
Unknown Object (File)
Sat, Jun 29, 5:44 PM
Unknown Object (File)
Thu, Jun 27, 3:40 AM
Unknown Object (File)
Wed, Jun 26, 1:44 PM
Unknown Object (File)
Tue, Jun 25, 12:04 PM
Unknown Object (File)
Tue, Jun 25, 12:04 PM
Unknown Object (File)
Tue, Jun 25, 12:04 PM
Unknown Object (File)
Tue, Jun 25, 12:04 PM
Subscribers

Details

Summary

The register_user_device (formerly create_device()) always registers a new user.
To manage device list, we need functions to login/logout devices of existing user.
Created functions that call Login and Logout identity RPCs.

Depends on D10420

Test Plan

Commtest builds, CI passes.
Functions' logic tested in the next diff.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Dec 21 2023, 3:45 AM

Looks exactly like the implementation from native_rust_library which works, LGTM

services/commtest/src/identity/device.rs
114 ↗(On Diff #34895)

probably you meant Login?

This revision is now accepted and ready to land.Jan 5 2024, 1:54 AM
services/commtest/src/identity/device.rs
114 ↗(On Diff #34895)

Yes 😅

114–117 ↗(On Diff #34895)