[commtest] Add functions to login/logout existing username
ClosedPublic
Actions

Authored by bartek on Dec 21 2023, 2:12 AM.

Details

Reviewers

kamil
michal
varun

Commits

rCOMM231725810f64: [commtest] Add functions to login/logout existing username

Summary

The register_user_device (formerly create_device()) always registers a new user.
To manage device list, we need functions to login/logout devices of existing user.
Created functions that call Login and Logout identity RPCs.

Depends on D10420

Test Plan

Commtest builds, CI passes.
Functions' logic tested in the next diff.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 21 2023, 2:12 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 21 2023, 2:12 AM

bartek added a child revision: D10422: [commtest] Add tests for Identity device list.Dec 21 2023, 2:15 AM

Harbormaster completed remote builds in B25262: Diff 34895.Dec 21 2023, 3:21 AM

bartek published this revision for review.Dec 21 2023, 3:45 AM

Looks exactly like the implementation from native_rust_library which works, LGTM

services/commtest/src/identity/device.rs
114 ↗	(On Diff #34895)	probably you meant `Login`?

This revision is now accepted and ready to land.Jan 5 2024, 1:54 AM

bartek added inline comments.Jan 5 2024, 2:01 AM

services/commtest/src/identity/device.rs
114 ↗	(On Diff #34895)	Yes 😅
114–117 ↗	(On Diff #34895)

Rebase. Address feedback

Harbormaster completed remote builds in B25630: Diff 35429.Jan 9 2024, 6:15 AM

Closed by commit rCOMM231725810f64: [commtest] Add functions to login/logout existing username (authored by bartek). · Explain WhyJan 9 2024, 6:25 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM231725810f64: [commtest] Add functions to login/logout existing username.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

identity/

device.rs

120 lines

Diff 35433

View Options

services/commtest/src/identity/device.rs

[commtest] Add functions to login/logout existing usernameClosedPublicActions