Details

Reviewers

varun
michal

Commits

rCOMM01d264725d0b: [identity] Add function to add new device to the list

Summary

Added a function that transactionally adds a new device to the device list and generate a new devicelist version. Details in D10219 where I used simplified version of this diff as a test plan.

Depends on D10219

Test Plan

Actually this function is extended version of the function in D10219 test plan. Test plans overlap, I just tested one more scenario:

Called this function twice - first one succeeded, second one failed with error message "Device already exists"

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 7 2023, 12:35 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 7 2023, 12:35 AM

bartek added a child revision: D10221: [identity] Add devices to the new list after login and register.Dec 7 2023, 12:38 AM

bartek published this revision for review.Dec 7 2023, 1:07 AM

bartek added inline comments.

services/identity/src/database/device_list.rs
73–74 ↗	(On Diff #34370)	Both `DeviceType`s refer the same enum in proto, but one is in the `grpc_clients` crate (client-specific) while the other is in Identity directly. They're exactly the same but to the compiler they are different structs. Decided to panic here because this happens only when the crate is badly compiled.