Page MenuHomePhabricator
Differential D10247

[identity] Add function to get device list history
ClosedPublic
Actions

Authored by bartek on Dec 8 2023, 4:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 11:49 AM
Unknown Object (File)
Tue, Jun 25, 11:49 AM
Unknown Object (File)
Tue, Jun 25, 11:49 AM
Unknown Object (File)
Tue, Jun 25, 11:49 AM
Unknown Object (File)
Tue, Jun 25, 11:49 AM
Unknown Object (File)
Tue, Jun 25, 11:49 AM
Unknown Object (File)
Wed, Jun 12, 3:43 PM
Unknown Object (File)
Thu, Jun 6, 11:05 PM
View All 35 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
michal
Commits
rCOMM230d6c05f67e: [identity] Add function to get device list history
Summary

Part of ENG-5049. Adds a function that queries all device list updates since given timestamp, or all updates ever if no timestamp is given.

Depends on D10246

Test Plan

Added three updates with to DDB.

  • Without timestamp, all three are returned.
  • Given timestamp T, where U1 < T < U2 < U3, the function returned U2 and U3.
  • Empty list is returned if timestamp is after all updates.
  • Empty list is returned if the user has no device lists yet.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Dec 8 2023, 4:45 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 4:45 AM
Harbormaster completed remote builds in B24884: Diff 34413.Dec 8 2023, 5:16 AM
bartek updated this revision to Diff 34508.EditedDec 11 2023, 11:29 PM

Move function into impl DatabaseClient

bartek added a child revision: D10301: [identity] Add GetDeviceListForUser RPC.Dec 12 2023, 12:55 AM
Harbormaster failed remote builds in B24970: Diff 34508!Dec 12 2023, 1:36 AM
bartek published this revision for review.Dec 12 2023, 3:20 AM
varun accepted this revision.Dec 19 2023, 8:25 PM
varun added inline comments.
services/identity/src/database/device_list.rs
433 ↗(On Diff #34508)

tiemstamp -> timestamp
deice -> device

This revision is now accepted and ready to land.Dec 19 2023, 8:25 PM
bartek updated this revision to Diff 34892.Dec 21 2023, 2:06 AM

Fix typos

Harbormaster completed remote builds in B25259: Diff 34892.Dec 21 2023, 2:38 AM
Closed by commit rCOMM230d6c05f67e: [identity] Add function to get device list history (authored by bartek). · Explain WhyJan 5 2024, 1:22 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM230d6c05f67e: [identity] Add function to get device list history.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
52 lines

Diff 35276

View Options

services/identity/src/database/device_list.rs

Loading...