[identity] Fix log_out_user DDB expression error
ClosedPublic
Actions

Authored by bartek on Dec 21 2023, 2:56 AM.

Details

Reviewers

varun
michal
kamil

Commits

rCOMM84437bdc18b4: [identity] Fix log_out_user DDB expression error

Summary

Noticed that log_out_user fails when deleting device from legacy DDB table. At least on Localstack.
The error thrown from update_item() call is as following:

ServiceError(ServiceError { source: UpdateItemError { kind: Unhandled(Unhandled { source: Error { code: Some("ValidationException"), message: Some("Invalid UpdateExpression: Internal server error"), ...)
`

Reading AWS docs, I noticed they either hardcode map keys or use expressio attribute names for map keys, not values. This solved the issue.
docs, example SO answer

Test Plan

Error log diappears in D10422 Commtest CI job after I rebased on this diff.
That diff is the first one that uses log_out_user function.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 21 2023, 2:56 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 21 2023, 2:56 AM

bartek added a child revision: D10422: [commtest] Add tests for Identity device list.Dec 21 2023, 3:14 AM

bartek added a child revision: D10397: [identity] Add function to remove device from list.

bartek published this revision for review.Dec 21 2023, 3:17 AM

bartek added inline comments.

services/identity/src/database.rs

700–705 ↗

(On Diff #34901)

We use expression_attribute_names for device ID key here and it works

This snippet is a bit unreadable, below is simplified version

let update_expression =
     format!("SET {}.#deviceID = :v", USERS_TABLE_DEVICES_ATTRIBUTE);
   let expression_attribute_names =
     HashMap::from([("#deviceID".to_string(), device_id.clone())]);
   let expression_attribute_values =
     HashMap::from([(":v".to_string(), AttributeValue::M(device_info))]);