Details

Reviewers

varun
michal

Commits

rCOMMb87de1144e69: [identity] Add devices to the new list after login and register

Summary

Updated LoginUser and RegisterUser DDB calls to double-write new device info to both "legacy" and new device list.

Depends on D10220

Test Plan

Used keyserver to first register, then login (after restart). Used awslocal dynamodb scan to inspect both tables - both were updated successfully.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 7 2023, 12:38 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 7 2023, 12:38 AM

I know the code is nearly duplicated: both password- and wallet- functions are nearly identical.
This is going to be refactored anyway when fully migrated to the new device list.
Now this is the least intrusive way to plug the new device list into existing codebase without introducing too much mess.

Harbormaster completed remote builds in B24849: Diff 34371.Dec 7 2023, 2:02 AM

bartek added a child revision: D10246: [identity] Add function to delete all user devices data.Dec 8 2023, 4:40 AM

varun accepted this revision.Dec 8 2023, 12:22 PM

This revision is now accepted and ready to land.Dec 8 2023, 12:22 PM

Rebase

Harbormaster completed remote builds in B24968: Diff 34506.Dec 12 2023, 1:12 AM

bartek removed a child revision: D10246: [identity] Add function to delete all user devices data.Jan 5 2024, 12:54 AM

bartek edited parent revisions, added: D10301: [identity] Add GetDeviceListForUser RPC; removed: D10220: [identity] Add function to add new device to the list.

bartek added a child revision: D10303: [identity] Augment get_keys_for_user to use devices table.

bartek edited child revisions, added: D10302: [identity] Make set_prekey() update devices table too; removed: D10303: [identity] Augment get_keys_for_user to use devices table.

Closed by commit rCOMMb87de1144e69: [identity] Add devices to the new list after login and register (authored by bartek). · Explain WhyJan 15 2024, 6:53 AM

This revision was automatically updated to reflect the committed changes.