Page MenuHomePhabricator
Differential D10303

[identity] Augment get_keys_for_user to use devices table
ClosedPublic
Actions

Authored by bartek on Dec 12 2023, 1:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 9:35 PM
Unknown Object (File)
Thu, Jun 27, 8:07 PM
Unknown Object (File)
Wed, Jun 26, 4:08 PM
Unknown Object (File)
Tue, Jun 25, 11:31 PM
Unknown Object (File)
Tue, Jun 25, 12:53 PM
Unknown Object (File)
Tue, Jun 25, 12:53 PM
Unknown Object (File)
Tue, Jun 25, 12:53 PM
Unknown Object (File)
Tue, Jun 25, 12:53 PM
View All 33 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
michal
Commits
rCOMM6b1d03f8fa40: [identity] Augment get_keys_for_user to use devices table
Summary

Updated DatabaseClient::get_keys_for_user to get device keys from devices table and fallback to users table if they're missing.

This code can be greatly simplified once we remove "legacy" devices attribute from users table.

Depends on D10302

Test Plan
  • Prepared two users: One with keys in both tables and one with keys only in users table
  • Called GetInboundKeysForUser and GetOutboundKeysForUser RPCs - they were able to fetch keys information for both users

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Dec 12 2023, 1:03 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 12 2023, 1:03 AM
bartek added a child revision: D10304: [identity] Augment get_keyserver_keys to use devices table.Dec 12 2023, 1:05 AM
Harbormaster completed remote builds in B24974: Diff 34512.Dec 12 2023, 1:57 AM
bartek published this revision for review.Dec 12 2023, 3:20 AM
varun accepted this revision.Dec 19 2023, 8:39 PM
varun added inline comments.
services/identity/src/database/device_list.rs
486 ↗(On Diff #34512)

compatibility

This revision is now accepted and ready to land.Dec 19 2023, 8:39 PM
bartek added inline comments.Dec 21 2023, 2:06 AM
services/identity/src/database/device_list.rs
486 ↗(On Diff #34512)

Thanks for catching all these typos (including my other diffs)! 🙏 This encouraged me to enable spellchecking in my editor so hopefully I'll do better in the future 😉

bartek updated this revision to Diff 34893.Dec 21 2023, 2:07 AM

Fix typo

Harbormaster completed remote builds in B25260: Diff 34893.Dec 21 2023, 3:01 AM
bartek added a parent revision: D10221: [identity] Add devices to the new list after login and register.Jan 5 2024, 12:54 AM
bartek removed a parent revision: D10221: [identity] Add devices to the new list after login and register.
Closed by commit rCOMM6b1d03f8fa40: [identity] Augment get_keys_for_user to use devices table (authored by bartek). · Explain WhyJan 15 2024, 6:53 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM6b1d03f8fa40: [identity] Augment get_keys_for_user to use devices table.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
12 lines
database/
63 lines

Diff 35623

View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/database/device_list.rs

Loading...