Page MenuHomePhabricator
Differential D10303

[identity] Augment get_keys_for_user to use devices table
ClosedPublic
Actions

Authored by bartek on Dec 12 2023, 1:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2025, 10:17 PM
Unknown Object (File)
Feb 20 2025, 10:17 PM
Unknown Object (File)
Feb 20 2025, 10:17 PM
Unknown Object (File)
Feb 20 2025, 10:17 PM
Unknown Object (File)
Feb 20 2025, 10:17 PM
Unknown Object (File)
Feb 18 2025, 8:30 AM
Unknown Object (File)
Jan 28 2025, 5:50 AM
Unknown Object (File)
Jan 21 2025, 7:38 PM
View All 76 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
michal
Commits
rCOMM6b1d03f8fa40: [identity] Augment get_keys_for_user to use devices table
Summary

Updated DatabaseClient::get_keys_for_user to get device keys from devices table and fallback to users table if they're missing.

This code can be greatly simplified once we remove "legacy" devices attribute from users table.

Depends on D10302

Test Plan
  • Prepared two users: One with keys in both tables and one with keys only in users table
  • Called GetInboundKeysForUser and GetOutboundKeysForUser RPCs - they were able to fetch keys information for both users

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Dec 12 2023, 1:03 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 12 2023, 1:03 AM
bartek added a child revision: D10304: [identity] Augment get_keyserver_keys to use devices table.Dec 12 2023, 1:05 AM
Harbormaster completed remote builds in B24974: Diff 34512.Dec 12 2023, 1:57 AM
bartek published this revision for review.Dec 12 2023, 3:20 AM
varun accepted this revision.Dec 19 2023, 8:39 PM
varun added inline comments.
services/identity/src/database/device_list.rs
486 ↗(On Diff #34512)

compatibility

This revision is now accepted and ready to land.Dec 19 2023, 8:39 PM
bartek added inline comments.Dec 21 2023, 2:06 AM
services/identity/src/database/device_list.rs
486 ↗(On Diff #34512)

Thanks for catching all these typos (including my other diffs)! 🙏 This encouraged me to enable spellchecking in my editor so hopefully I'll do better in the future 😉

bartek updated this revision to Diff 34893.Dec 21 2023, 2:07 AM

Fix typo

Harbormaster completed remote builds in B25260: Diff 34893.Dec 21 2023, 3:01 AM
bartek added a parent revision: D10221: [identity] Add devices to the new list after login and register.Jan 5 2024, 12:54 AM
bartek removed a parent revision: D10221: [identity] Add devices to the new list after login and register.
Closed by commit rCOMM6b1d03f8fa40: [identity] Augment get_keys_for_user to use devices table (authored by bartek). · Explain WhyJan 15 2024, 6:53 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM6b1d03f8fa40: [identity] Augment get_keys_for_user to use devices table.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
15 lines
database/
63 lines

Diff 34893

View Options

services/identity/src/database.rs

Show All 31 Lines egress {
to_port = 0 to_port = 0
protocol = "-1" protocol = "-1"
cidr_blocks = ["0.0.0.0/0"] cidr_blocks = ["0.0.0.0/0"]
} }
} }
# MariaDB RDS Instance # MariaDB RDS Instance
resource "aws_db_instance" "mariadb" { resource "aws_db_instance" "mariadb" {
allocated_storage = 100 allocated_storage = 100
max_allocated_storage = 3000 max_allocated_storage = 3000
storage_type = "gp3" storage_type = "gp3"
db_name = "mariadb" db_name = "mariadb"
identifier = "mariadb-instance" identifier = "mariadb-instance"
engine = "mariadb" engine = "mariadb"
engine_version = "10.11" engine_version = "10.11"
backup_retention_period = 7
instance_class = var.db_instance_class instance_class = var.db_instance_class
db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name
vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id] vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id]
username = local.mariadb_username username = local.mariadb_username
password = local.mariadb_password password = local.mariadb_password
parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name
storage_encrypted = true storage_encrypted = true
publicly_accessible = true publicly_accessible = true
port = local.mariadb_port port = local.mariadb_port
skip_final_snapshot = true skip_final_snapshot = true
} }
# MariaDB Parameter Group # MariaDB Parameter Group
resource "aws_db_parameter_group" "mariadb_parameter_group" { resource "aws_db_parameter_group" "mariadb_parameter_group" {
name = "mariadb-parameter-group" name = "mariadb-parameter-group"
family = "mariadb10.11" family = "mariadb10.11"
parameter { parameter {
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines
View Options

services/identity/src/database/device_list.rs

Show All 31 Lines egress {
to_port = 0 to_port = 0
protocol = "-1" protocol = "-1"
cidr_blocks = ["0.0.0.0/0"] cidr_blocks = ["0.0.0.0/0"]
} }
} }
# MariaDB RDS Instance # MariaDB RDS Instance
resource "aws_db_instance" "mariadb" { resource "aws_db_instance" "mariadb" {
allocated_storage = 100 allocated_storage = 100
max_allocated_storage = 3000 max_allocated_storage = 3000
storage_type = "gp3" storage_type = "gp3"
db_name = "mariadb" db_name = "mariadb"
identifier = "mariadb-instance" identifier = "mariadb-instance"
engine = "mariadb" engine = "mariadb"
engine_version = "10.11" engine_version = "10.11"
backup_retention_period = 7
instance_class = var.db_instance_class instance_class = var.db_instance_class
db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name
vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id] vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id]
username = local.mariadb_username username = local.mariadb_username
password = local.mariadb_password password = local.mariadb_password
parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name
storage_encrypted = true storage_encrypted = true
publicly_accessible = true publicly_accessible = true
port = local.mariadb_port port = local.mariadb_port
skip_final_snapshot = true skip_final_snapshot = true
} }
# MariaDB Parameter Group # MariaDB Parameter Group
resource "aws_db_parameter_group" "mariadb_parameter_group" { resource "aws_db_parameter_group" "mariadb_parameter_group" {
name = "mariadb-parameter-group" name = "mariadb-parameter-group"
family = "mariadb10.11" family = "mariadb10.11"
parameter { parameter {
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines