Paths

Table of Contentst

[commtest] Rename create_device to register_user_device
ClosedPublic
Actions

Authored by bartek on Dec 21 2023, 2:09 AM.

Details

Reviewers

kamil
michal
varun

Commits

rCOMM7f5669d78e98: [commtest] Rename create_device to register_user_device

Summary

The create_device wasn't very accurate name. What the function does is:

Register a new user
Upload keys for its primary device

Also added a DeviceType optional argument to the function which will be needed late optional argument to the function which will be needed later.

Depends on D10404

Test Plan

Commtest builds, CommTest CI

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 21 2023, 2:09 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 21 2023, 2:09 AM

bartek added a child revision: D10421: [commtest] Add functions to login/logout existing username.Dec 21 2023, 2:12 AM

Harbormaster completed remote builds in B25261: Diff 34894.Dec 21 2023, 3:13 AM

bartek published this revision for review.Dec 21 2023, 3:45 AM

Look cleaner now

This revision is now accepted and ready to land.Jan 5 2024, 1:37 AM

bartek removed a parent revision: D10404: [identity] Reorder device list when updated.Jan 9 2024, 5:51 AM

Closed by commit rCOMM7f5669d78e98: [commtest] Rename create_device to register_user_device (authored by bartek). · Explain WhyJan 9 2024, 6:25 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM7f5669d78e98: [commtest] Rename create_device to register_user_device.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

identity/

device.rs

12 lines

tests/

grpc_client_test.rs

4 lines

identity_access_tokens_tests.rs

4 lines

identity_integration_tests.rs

4 lines

identity_keyserver_tests.rs

4 lines

identity_one_time_key_tests.rs

4 lines

identity_prekey_tests.rs

4 lines

identity_tunnelbroker_tests.rs

10 lines

tunnelbroker_heartbeat_tests.rs

8 lines

tunnelbroker_integration_tests.rs

8 lines

tunnelbroker_persist_tests.rs

8 lines

tunnelbroker_recipient_confirmation_tests.rs

18 lines

tunnelbroker_sender_confirmation_tests.rs

10 lines

tunnelbroker_websocket_messages_tests.rs

6 lines

Diff 35432

View Options

services/commtest/src/identity/device.rs

View Options

services/commtest/tests/grpc_client_test.rs

View Options

services/commtest/tests/identity_access_tokens_tests.rs

View Options

services/commtest/tests/identity_integration_tests.rs

View Options

services/commtest/tests/identity_keyserver_tests.rs

View Options

services/commtest/tests/identity_one_time_key_tests.rs

View Options

services/commtest/tests/identity_prekey_tests.rs

View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

View Options

services/commtest/tests/tunnelbroker_heartbeat_tests.rs

View Options

services/commtest/tests/tunnelbroker_integration_tests.rs

View Options

services/commtest/tests/tunnelbroker_persist_tests.rs

View Options

services/commtest/tests/tunnelbroker_recipient_confirmation_tests.rs

View Options

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

View Options

services/commtest/tests/tunnelbroker_websocket_messages_tests.rs

[commtest] Rename create_device to register_user_deviceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35432

services/commtest/src/identity/device.rs

services/commtest/tests/grpc_client_test.rs

services/commtest/tests/identity_access_tokens_tests.rs

services/commtest/tests/identity_integration_tests.rs

services/commtest/tests/identity_keyserver_tests.rs

services/commtest/tests/identity_one_time_key_tests.rs

services/commtest/tests/identity_prekey_tests.rs

services/commtest/tests/identity_tunnelbroker_tests.rs

services/commtest/tests/tunnelbroker_heartbeat_tests.rs

services/commtest/tests/tunnelbroker_integration_tests.rs

services/commtest/tests/tunnelbroker_persist_tests.rs

services/commtest/tests/tunnelbroker_recipient_confirmation_tests.rs

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

services/commtest/tests/tunnelbroker_websocket_messages_tests.rs

[commtest] Rename create_device to register_user_device
ClosedPublic
Actions

Revision Contents
Changeset List