Paths

Table of Contentst

Differential D11406

[identity] link farcaster account implementation
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 12:55 PM.

Details

Reviewers

bartek

Commits

rCOMMf1d96072c6f2: [identity] link farcaster account implementation

Summary

use ddb update-item to add a farcaster ID to a user item. later in the stack, we add a conditon to avoid overwriting an existing farcasterID

Depends on D11405

Test Plan

RPC is called from native and web later in the stack

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Mar 27 2024, 12:55 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2024, 12:55 PM

varun added a child revision: D11407: [native_rust_library] implement link_farcaster_account client method.Mar 27 2024, 12:58 PM

Harbormaster completed remote builds in B27721: Diff 38384.Mar 27 2024, 1:23 PM

varun requested review of this revision.Mar 27 2024, 1:23 PM

bartek accepted this revision.Mar 27 2024, 11:05 PM

bartek added inline comments.

services/identity/src/database/farcaster.rs
78	Might be a bit cleaner to use builder pattern here instead of `Some`s and `HashMap`s

This revision is now accepted and ready to land.Mar 27 2024, 11:05 PM

varun added inline comments.Mar 28 2024, 2:45 PM

services/identity/src/database/farcaster.rs
78	agreed, cleaned it up

Closed by commit rCOMMf1d96072c6f2: [identity] link farcaster account implementation (authored by varun). · Explain WhyMar 28 2024, 3:13 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMf1d96072c6f2: [identity] link farcaster account implementation.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

farcaster.rs

26 lines

grpc_services/

authenticated.rs

14 lines

Diff 38384

View Options

services/identity/src/database/farcaster.rs