Page MenuHomePhabricator
Differential D12138

Implement SQLite API to handle entry store
ClosedPublic
Actions

Authored by marcin on May 21 2024, 3:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 1:53 PM
Unknown Object (File)
Sun, Nov 10, 1:38 AM
Unknown Object (File)
Fri, Nov 8, 10:46 AM
Unknown Object (File)
Fri, Nov 8, 8:47 AM
Unknown Object (File)
Sat, Nov 2, 1:03 AM
Unknown Object (File)
Fri, Nov 1, 7:20 PM
Unknown Object (File)
Oct 2 2024, 6:19 PM
Unknown Object (File)
Oct 2 2024, 6:19 PM
View All 44 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM34fae12d44fa: Implement SQLite API to handle entry store
Summary

This differential implements SQLiteQueryExecutor API necessary to persist entry store.

Test Plan

Compile

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.May 21 2024, 3:24 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 3:24 AM
marcin added a parent revision: D12137: [lib] Create entry store operations.May 21 2024, 3:25 AM
marcin added inline comments.
web/shared-worker/queries/entry-queries.test.js
38–55 ↗(On Diff #40449)

This will be removed soon as @tomek is implementing it in his files.

Harbormaster completed remote builds in B29086: Diff 40449.May 21 2024, 3:40 AM
marcin requested review of this revision.May 21 2024, 3:40 AM
marcin added a child revision: D12142: Implement JSI for EntryStore.May 21 2024, 6:15 AM
tomek accepted this revision.May 21 2024, 6:17 AM
This revision is now accepted and ready to land.May 21 2024, 6:17 AM
marcin updated this revision to Diff 40463.May 21 2024, 6:55 AM

entry_info -> entry

Harbormaster completed remote builds in B29099: Diff 40463.May 21 2024, 7:18 AM
marcin updated this revision to Diff 40473.May 21 2024, 7:46 AM

Rebase

tomek edited parent revisions, added: D12141: [lib] Create entry store handler; removed: D12137: [lib] Create entry store operations.May 21 2024, 7:53 AM
Harbormaster completed remote builds in B29107: Diff 40473.May 21 2024, 8:08 AM
marcin edited the test plan for this revision. (Show Details)May 22 2024, 8:44 AM
Closed by commit rCOMM34fae12d44fa: Implement SQLite API to handle entry store (authored by marcin). · Explain WhyMay 27 2024, 5:45 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM34fae12d44fa: Implement SQLite API to handle entry store.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
5 lines
4 lines
55 lines
entities/
23 lines
web/
cpp/
7 lines
shared-worker/
_generated/
queries/
116 lines
types/
6 lines

Diff 40463

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/EntryInfo.h

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/entry-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...