Paths

Table of Contentst

Implement SQLite API to handle entry store
ClosedPublic
Actions

Authored by marcin on May 21 2024, 10:24 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM34fae12d44fa: Implement SQLite API to handle entry store

Summary

This differential implements SQLiteQueryExecutor API necessary to persist entry store.

Test Plan

Compile

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.May 21 2024, 10:24 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 10:24 AM

marcin added a parent revision: D12137: [lib] Create entry store operations.May 21 2024, 10:25 AM

marcin added inline comments.

web/shared-worker/queries/entry-queries.test.js
38–55 ↗	(On Diff #40449)	This will be removed soon as @tomek is implementing it in his files.

Harbormaster completed remote builds in B29086: Diff 40449.May 21 2024, 10:40 AM

marcin requested review of this revision.May 21 2024, 10:40 AM

marcin added a child revision: D12142: Implement JSI for EntryStore.May 21 2024, 1:15 PM

tomek accepted this revision.May 21 2024, 1:17 PM

This revision is now accepted and ready to land.May 21 2024, 1:17 PM

entry_info -> entry

Harbormaster completed remote builds in B29099: Diff 40463.May 21 2024, 2:18 PM

Rebase

tomek edited parent revisions, added: D12141: [lib] Create entry store handler; removed: D12137: [lib] Create entry store operations.May 21 2024, 2:53 PM

Harbormaster completed remote builds in B29107: Diff 40473.May 21 2024, 3:08 PM

marcin edited the test plan for this revision. (Show Details)May 22 2024, 3:44 PM

Closed by commit rCOMM34fae12d44fa: Implement SQLite API to handle entry store. · Explain WhyMay 27 2024, 12:45 PM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM34fae12d44fa: Implement SQLite API to handle entry store.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

5 lines

SQLiteQueryExecutor.h

4 lines

SQLiteQueryExecutor.cpp

55 lines

entities/

EntryInfo.h

23 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

7 lines

shared-worker/

_generated/

comm_query_executor.wasm

queries/

entry-queries.test.js

116 lines

types/

sqlite-query-executor.js

6 lines

Diff 40658

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/EntryInfo.h

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

View Options

web/shared-worker/_generated/comm_query_executor.wasm

View Options

web/shared-worker/queries/entry-queries.test.js

View Options

web/shared-worker/types/sqlite-query-executor.js

Implement SQLite API to handle entry storeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40658

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/EntryInfo.h

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/entry-queries.test.js

web/shared-worker/types/sqlite-query-executor.js

Implement SQLite API to handle entry store
ClosedPublic
Actions

Revision Contents
Changeset List