Paths

Table of Contentst

Differential D12371

[lib] move processing `MESSAGE_TO_DEVICE` to a component
ClosedPublic
Actions

Authored by kamil on Jun 10 2024, 4:10 AM.

Tags

None

Referenced Files

	F3361829: D12371.diff
	Sun, Nov 24, 7:37 PM

	Unknown Object (File)
	Wed, Nov 20, 2:40 PM

	Unknown Object (File)
	Wed, Nov 20, 2:40 PM

	Unknown Object (File)
	Fri, Nov 8, 7:14 PM

	Unknown Object (File)
	Fri, Nov 8, 1:52 PM

	Unknown Object (File)
	Fri, Nov 1, 11:47 PM

	Unknown Object (File)
	Oct 22 2024, 1:15 PM

	Unknown Object (File)
	Oct 22 2024, 9:05 AM

View All 62 Files

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMMc5dc4cd1873a: [lib] move processing `MESSAGE_TO_DEVICE` to a component

Summary

Cleans messy TunnelbrokerContext
Makes it possible to convert peerToPeerMessageHandler to a hook and avoids passing a lot of callbacks as arguments
Makes it possible to call sendMessage from peerToPeerMessageHandler (needed to implement ENG-7837).

Test Plan

Flow - this is just moving code to a child component. Functionality tested later in the stack.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 10 2024, 4:10 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 4:10 AM

kamil added a child revision: D12372: [lib] convert `peerToPeerMessageHandler` to a hook.Jun 10 2024, 4:19 AM

Harbormaster completed remote builds in B29564: Diff 41151.Jun 10 2024, 4:26 AM

kamil edited the summary of this revision. (Show Details)Jun 10 2024, 9:38 AM

kamil added inline comments.

lib/tunnelbroker/tunnelbroker-context.js
395–404 ↗	(On Diff #41151)	not sure about best practices but this feels the best for this particular use case (passing ref as prop and reading it from promise later)

kamil published this revision for review.Jun 10 2024, 9:50 AM

ashoat added inline comments.Jun 10 2024, 1:32 PM

lib/tunnelbroker/tunnelbroker-context.js
422 ↗	(On Diff #41151)	Unusual pattern to use "if" in a `boolean` variable name How about `doesSocketExist`?

tomek accepted this revision.Jun 12 2024, 4:25 AM

This revision is now accepted and ready to land.Jun 12 2024, 4:25 AM

bartek accepted this revision.Jun 12 2024, 8:41 AM

ifSocketExists -> doesSocketExist

Harbormaster completed remote builds in B29660: Diff 41284.Jun 13 2024, 8:00 AM

Closed by commit rCOMMc5dc4cd1873a: [lib] move processing `MESSAGE_TO_DEVICE` to a component (authored by kamil). · Explain WhyJun 13 2024, 9:08 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMc5dc4cd1873a: [lib] move processing `MESSAGE_TO_DEVICE` to a component.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

peer-to-peer-message-handler.js

111 lines

tunnelbroker-context.js

87 lines

Diff 41295

lib/tunnelbroker/peer-to-peer-message-handler.js

Loading...

lib/tunnelbroker/tunnelbroker-context.js

Loading...