[lib] Deprecate `updateRolesAndPermissions`
AcceptedPublic
Actions

Authored by atul on Thu, Jun 27, 2:05 PM.

Details

Reviewers

ashoat

Summary

We want to deprecate this function because it's no longer relevant for *RawThreadInfos without member permissions.

We're keeping it around to ensure existing migrations work as expected.

Depends on D12598

Test Plan

This diff is just a rename to make it clear function shouldn't be used in future. Looked at all callsites and ensured there's nothing preventing function from being deprecated.

Diff Detail

Repository

rCOMM Comm

Branch

july26 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Thu, Jun 27, 2:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptThu, Jun 27, 2:05 PM

atul published this revision for review.Thu, Jun 27, 2:14 PM

atul added a child revision: D12601: [lib] Add `flow` suppression to `deprecatedDecodeMinimallyEncodedRawThreadInfo`.Thu, Jun 27, 2:16 PM

Harbormaster failed remote builds in B29973: Diff 41772!Thu, Jun 27, 2:19 PM

Is the idea here that we'll never need to run deprecatedUpdateRolesAndPermissions again when we change permissions, since we're not storing the permissions in the ThreadStore at all?

And that permission checks in the future will be computed on-the-fly based on the user's role in the relevant thread and its ancestors?

This revision is now accepted and ready to land.Mon, Jul 1, 1:05 PM