Page MenuHomePhabricator
Differential D12599

[lib] Deprecate `updateRolesAndPermissions`
ClosedPublic
Actions

Authored by atul on Jun 27 2024, 2:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 4:06 AM
Unknown Object (File)
Feb 21 2025, 2:51 PM
Unknown Object (File)
Feb 6 2025, 1:07 PM
Unknown Object (File)
Feb 6 2025, 1:07 PM
Unknown Object (File)
Feb 6 2025, 1:07 PM
Unknown Object (File)
Feb 6 2025, 1:07 PM
Unknown Object (File)
Feb 6 2025, 1:07 PM
Unknown Object (File)
Feb 6 2025, 1:07 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMMfc1e4abe9c83: [lib] Deprecate `updateRolesAndPermissions`
rCOMMad00e8286547: [lib] Deprecate `updateRolesAndPermissions`
Summary

We want to deprecate this function because it's no longer relevant for *RawThreadInfos without member permissions.

We're keeping it around to ensure existing migrations work as expected.

Depends on D12598

Test Plan

This diff is just a rename to make it clear function shouldn't be used in future. Looked at all callsites and ensured there's nothing preventing function from being deprecated.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 27 2024, 2:05 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2024, 2:05 PM
atul published this revision for review.Jun 27 2024, 2:14 PM
atul added a child revision: D12601: [lib] Add `flow` suppression to `deprecatedDecodeMinimallyEncodedRawThreadInfo`.Jun 27 2024, 2:16 PM
Harbormaster failed remote builds in B29973: Diff 41772!Jun 27 2024, 2:19 PM
ashoat accepted this revision.Jul 1 2024, 1:05 PM

Is the idea here that we'll never need to run deprecatedUpdateRolesAndPermissions again when we change permissions, since we're not storing the permissions in the ThreadStore at all?

And that permission checks in the future will be computed on-the-fly based on the user's role in the relevant thread and its ancestors?

This revision is now accepted and ready to land.Jul 1 2024, 1:05 PM
atul updated this revision to Diff 42155.Jul 9 2024, 11:05 AM

resolve merge conflict

Harbormaster failed remote builds in B30232: Diff 42155!Jul 9 2024, 11:19 AM
atul updated this revision to Diff 42168.Jul 9 2024, 12:36 PM

resequence

atul added a comment.Jul 9 2024, 12:37 PM

Safe to land out of order since it's purely rename

This revision was landed with ongoing or failed builds.Jul 9 2024, 12:42 PM
Closed by commit rCOMMad00e8286547: [lib] Deprecate `updateRolesAndPermissions` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMad00e8286547: [lib] Deprecate `updateRolesAndPermissions`.
Harbormaster failed remote builds in B30238: Diff 42168!Jul 9 2024, 12:50 PM
atul added a reverting change: rCOMM1377f88ecd03: Revert "[lib] Deprecate `updateRolesAndPermissions`".Jul 9 2024, 1:15 PM
atul reopened this revision.Jul 9 2024, 1:17 PM
This revision is now accepted and ready to land.Jul 9 2024, 1:17 PM
atul updated this revision to Diff 42171.Jul 9 2024, 1:17 PM

re-open to address eslint thing

atul added a comment.Jul 9 2024, 1:27 PM

JK, the ESLint issue was in revision one before the one that landed. Re-landing.

This revision was landed with ongoing or failed builds.Jul 9 2024, 1:27 PM
Closed by commit rCOMMfc1e4abe9c83: [lib] Deprecate `updateRolesAndPermissions` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMfc1e4abe9c83: [lib] Deprecate `updateRolesAndPermissions`.
Harbormaster completed remote builds in B30239: Diff 42171.Jul 9 2024, 1:35 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
redux/
deprecated-update-roles-and-permissions.js
update-roles-and-permissions.js
4 lines
native/
redux/
4 lines
web/
redux/
4 lines

Diff 42171

View Options

lib/shared/redux/deprecated-update-roles-and-permissions.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

lib/shared/redux/update-roles-and-permissions.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

native/redux/persist.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

web/redux/persist.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines