Page MenuHomePhabricator
Differential D12850

[SQLite] add Emscripten bindings for message search
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 2:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 10:07 AM
Unknown Object (File)
Tue, Apr 22, 2:00 AM
Unknown Object (File)
Mon, Apr 21, 8:44 PM
Unknown Object (File)
Mon, Apr 21, 1:11 PM
Unknown Object (File)
Mar 23 2025, 10:40 AM
Unknown Object (File)
Mar 11 2025, 3:41 PM
Unknown Object (File)
Feb 21 2025, 3:32 AM
Unknown Object (File)
Feb 21 2025, 3:32 AM
View All 78 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMffb88c4a6c6d: [SQLite] add Emscripten bindings for message search
Summary

Making method available in .wasm.

Depends on D12844

Test Plan

Tested in D12851

Diff Detail

Repository
rCOMM Comm
Branch
cpp-search-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 23 2024, 2:53 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 2:53 AM
kamil added a child revision: D12851: [SQLite] implement tests for messages search.Jul 23 2024, 2:54 AM
kamil retitled this revision from [SQLite] add Emscripten bindings to [SQLite] add Emscripten bindings for message search.Jul 23 2024, 2:55 AM
kamil edited the test plan for this revision. (Show Details)
kamil updated this revision to Diff 42669.Jul 23 2024, 3:04 AM

rebase

Harbormaster failed remote builds in B30593: Diff 42667!Jul 23 2024, 3:14 AM
Harbormaster completed remote builds in B30595: Diff 42669.Jul 23 2024, 3:25 AM
kamil published this revision for review.Jul 23 2024, 5:03 AM
tomek accepted this revision.Jul 23 2024, 6:16 AM
This revision is now accepted and ready to land.Jul 23 2024, 6:16 AM
Closed by commit rCOMMffb88c4a6c6d: [SQLite] add Emscripten bindings for message search (authored by kamil). · Explain WhyJul 23 2024, 8:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMffb88c4a6c6d: [SQLite] add Emscripten bindings for message search.

Revision Contents
Changeset List

PathSize
web/
cpp/
3 lines
shared-worker/
types/
6 lines

Diff 42667

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { useBroadcastDeviceListUpdates } from '../hooks/peer-list-hooks.js'; import {
useBroadcastDeviceListUpdates,
useBroadcastAccountDeletion,
} from '../hooks/peer-list-hooks.js';
import type { import type {
CallSingleKeyserverEndpoint, CallSingleKeyserverEndpoint,
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
} from '../keyserver-conn/call-single-keyserver-endpoint.js'; } from '../keyserver-conn/call-single-keyserver-endpoint.js';
import { import {
extractKeyserverIDFromID, extractKeyserverIDFromID,
sortThreadIDsPerKeyserver, sortThreadIDsPerKeyserver,
sortCalendarQueryPerKeyserver, sortCalendarQueryPerKeyserver,
▲ Show 20 Lines • Show All 486 Lines • ▼ Show 20 Lines
} }
const deleteAccountActionTypes = Object.freeze({ const deleteAccountActionTypes = Object.freeze({
started: 'DELETE_ACCOUNT_STARTED', started: 'DELETE_ACCOUNT_STARTED',
success: 'DELETE_ACCOUNT_SUCCESS', success: 'DELETE_ACCOUNT_SUCCESS',
failed: 'DELETE_ACCOUNT_FAILED', failed: 'DELETE_ACCOUNT_FAILED',
}); });
const accountDeletionBroadcastOptions = Object.freeze({
broadcastToOwnDevices: true,
});
function useDeleteAccount(): (password: ?string) => Promise<LogOutResult> { function useDeleteAccount(): (password: ?string) => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
const broadcastAccountDeletion = useBroadcastAccountDeletion(
accountDeletionBroadcastOptions,
);
const preRequestUserState = usePreRequestUserState(); const preRequestUserState = usePreRequestUserState();
const callKeyserverDeleteAccount = useKeyserverCall(deleteKeyserverAccount); const callKeyserverDeleteAccount = useKeyserverCall(deleteKeyserverAccount);
const commServicesAccessToken = useSelector( const commServicesAccessToken = useSelector(
state => state.commServicesAccessToken, state => state.commServicesAccessToken,
); );
return React.useCallback( return React.useCallback(
async password => { async password => {
if (usingCommServicesAccessToken) { if (usingCommServicesAccessToken) {
if (!identityClient) { if (!identityClient) {
throw new Error('Identity service client is not initialized'); throw new Error('Identity service client is not initialized');
} }
if ( const { deleteWalletUser, deletePasswordUser } = identityClient;
!identityClient.deleteWalletUser || if (!deleteWalletUser || !deletePasswordUser) {
bartekAuthorUnsubmitted
Done
Inline Actions

This is because of Flow not being able to infer these as non-null after await broadcastAccountDeletion(); was called

bartek: This is because of Flow not being able to infer these as non-null after `await…
!identityClient.deletePasswordUser
) {
throw new Error('Delete user method unimplemented'); throw new Error('Delete user method unimplemented');
} }
await broadcastAccountDeletion();
if (password) { if (password) {
await identityClient.deletePasswordUser(password); await deletePasswordUser(password);
} else { } else {
await identityClient.deleteWalletUser(); await deleteWalletUser();
} }
} }
try { try {
const keyserverResult = await callKeyserverDeleteAccount({ const keyserverResult = await callKeyserverDeleteAccount({
preRequestUserState, preRequestUserState,
}); });
const { keyserverIDs: _, ...result } = keyserverResult; const { keyserverIDs: _, ...result } = keyserverResult;
return { return {
Show All 16 Lines async password => {
currentUserInfo: null, currentUserInfo: null,
preRequestUserState: { preRequestUserState: {
...preRequestUserState, ...preRequestUserState,
commServicesAccessToken, commServicesAccessToken,
}, },
}; };
}, },
[ [
broadcastAccountDeletion,
callKeyserverDeleteAccount, callKeyserverDeleteAccount,
commServicesAccessToken, commServicesAccessToken,
identityClient, identityClient,
preRequestUserState, preRequestUserState,
], ],
); );
} }
▲ Show 20 Lines • Show All 887 Lines • Show Last 20 Lines
View Options

web/shared-worker/types/sqlite-query-executor.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { useBroadcastDeviceListUpdates } from '../hooks/peer-list-hooks.js'; import {
useBroadcastDeviceListUpdates,
useBroadcastAccountDeletion,
} from '../hooks/peer-list-hooks.js';
import type { import type {
CallSingleKeyserverEndpoint, CallSingleKeyserverEndpoint,
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
} from '../keyserver-conn/call-single-keyserver-endpoint.js'; } from '../keyserver-conn/call-single-keyserver-endpoint.js';
import { import {
extractKeyserverIDFromID, extractKeyserverIDFromID,
sortThreadIDsPerKeyserver, sortThreadIDsPerKeyserver,
sortCalendarQueryPerKeyserver, sortCalendarQueryPerKeyserver,
▲ Show 20 Lines • Show All 486 Lines • ▼ Show 20 Lines
} }
const deleteAccountActionTypes = Object.freeze({ const deleteAccountActionTypes = Object.freeze({
started: 'DELETE_ACCOUNT_STARTED', started: 'DELETE_ACCOUNT_STARTED',
success: 'DELETE_ACCOUNT_SUCCESS', success: 'DELETE_ACCOUNT_SUCCESS',
failed: 'DELETE_ACCOUNT_FAILED', failed: 'DELETE_ACCOUNT_FAILED',
}); });
const accountDeletionBroadcastOptions = Object.freeze({
broadcastToOwnDevices: true,
});
function useDeleteAccount(): (password: ?string) => Promise<LogOutResult> { function useDeleteAccount(): (password: ?string) => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
const broadcastAccountDeletion = useBroadcastAccountDeletion(
accountDeletionBroadcastOptions,
);
const preRequestUserState = usePreRequestUserState(); const preRequestUserState = usePreRequestUserState();
const callKeyserverDeleteAccount = useKeyserverCall(deleteKeyserverAccount); const callKeyserverDeleteAccount = useKeyserverCall(deleteKeyserverAccount);
const commServicesAccessToken = useSelector( const commServicesAccessToken = useSelector(
state => state.commServicesAccessToken, state => state.commServicesAccessToken,
); );
return React.useCallback( return React.useCallback(
async password => { async password => {
if (usingCommServicesAccessToken) { if (usingCommServicesAccessToken) {
if (!identityClient) { if (!identityClient) {
throw new Error('Identity service client is not initialized'); throw new Error('Identity service client is not initialized');
} }
if ( const { deleteWalletUser, deletePasswordUser } = identityClient;
!identityClient.deleteWalletUser || if (!deleteWalletUser || !deletePasswordUser) {
bartekAuthorUnsubmitted
Done
Inline Actions

This is because of Flow not being able to infer these as non-null after await broadcastAccountDeletion(); was called

bartek: This is because of Flow not being able to infer these as non-null after `await…
!identityClient.deletePasswordUser
) {
throw new Error('Delete user method unimplemented'); throw new Error('Delete user method unimplemented');
} }
await broadcastAccountDeletion();
if (password) { if (password) {
await identityClient.deletePasswordUser(password); await deletePasswordUser(password);
} else { } else {
await identityClient.deleteWalletUser(); await deleteWalletUser();
} }
} }
try { try {
const keyserverResult = await callKeyserverDeleteAccount({ const keyserverResult = await callKeyserverDeleteAccount({
preRequestUserState, preRequestUserState,
}); });
const { keyserverIDs: _, ...result } = keyserverResult; const { keyserverIDs: _, ...result } = keyserverResult;
return { return {
Show All 16 Lines async password => {
currentUserInfo: null, currentUserInfo: null,
preRequestUserState: { preRequestUserState: {
...preRequestUserState, ...preRequestUserState,
commServicesAccessToken, commServicesAccessToken,
}, },
}; };
}, },
[ [
broadcastAccountDeletion,
callKeyserverDeleteAccount, callKeyserverDeleteAccount,
commServicesAccessToken, commServicesAccessToken,
identityClient, identityClient,
preRequestUserState, preRequestUserState,
], ],
); );
} }
▲ Show 20 Lines • Show All 887 Lines • Show Last 20 Lines