[native] Copy tooltip
ClosedPublic
Actions

Authored by inka on Jul 30 2024, 5:30 AM.

Details

Reviewers

tomek
will

Commits

rCOMM747ad18847dd: [native] Copy tooltip

Summary

isssue: ENG-8882
This diff only copies the tooltip code. This is to make the next diff - which will be removing code irrelevant to nux tips tooltip from this copy - easier to review

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Branch

inka/nux

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jul 30 2024, 5:30 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 30 2024, 5:30 AM

Rename file - I am not sure how to name this, but this seems better

inka added a child revision: D12942: [native] Remove irrelevant code from nux tips overlay.Jul 30 2024, 5:38 AM

Harbormaster completed remote builds in B30810: Diff 42959.Jul 30 2024, 6:28 AM

Harbormaster completed remote builds in B30811: Diff 42960.Jul 30 2024, 6:36 AM

inka requested review of this revision.Jul 30 2024, 6:36 AM

In D12941#365887, @inka wrote:

Rename file - I am not sure how to name this, but this seems better

Discussed offline - we think the current name makes sense.

This revision is now accepted and ready to land.Jul 31 2024, 6:04 AM

Closed by commit rCOMM747ad18847dd: [native] Copy tooltip (authored by inka). · Explain WhyAug 13 2024, 5:42 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM747ad18847dd: [native] Copy tooltip.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

605 lines

Diff 42960

View Options

native/tooltip/nux-tips-overlay.react.js

[native] Copy tooltipClosedPublicActions