Page MenuHomePhabricator

[native] Remove irrelevant code from nux tips overlay
ClosedPublic

Authored by inka on Jul 30 2024, 5:38 AM.
Tags
None
Referenced Files
F3203840: D12942.diff
Sat, Nov 9, 8:28 PM
Unknown Object (File)
Wed, Nov 6, 11:33 PM
Unknown Object (File)
Sun, Nov 3, 2:34 AM
Unknown Object (File)
Sun, Nov 3, 2:34 AM
Unknown Object (File)
Sun, Oct 20, 3:37 PM
Unknown Object (File)
Sat, Oct 19, 8:23 AM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Subscribers

Details

Summary

issue: ENG-8882
Removing code that is irrelevant to nux overlay.
Mind that this diff is only supposed to be removing unnecessary code. Name changes and so on will follow in the next diffs

Test Plan

Tested by creating a component wuth this createTooltip, and navigating to it. It appears correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/tooltip/nux-tips-overlay.react.js
119 ↗(On Diff #42961)

This will be updated in later diffs

122 ↗(On Diff #42961)

We will always have the tooltip be "below"

124 ↗(On Diff #42961)

We will be displaying text, not a list of entries

125 ↗(On Diff #42961)

We will be displaying the tips in a place where chat input bar is not present

228 ↗(On Diff #42961)

This is vibration. I don't think we want the phone to vibrate when showing tips

297–302 ↗(On Diff #42961)

We don't need this customisation

386–390 ↗(On Diff #42961)

This was moved directly to tooltip. In later diffs MenuComponent will be replaced with some fixed component that only takes text

424–425 ↗(On Diff #42961)

Because the nux tips will always be below the item they are pointing to, we only need the triangleUp

435 ↗(On Diff #42961)

This is needed for transitions when opening a sidebar and the message slides into the sidebar. We don't need this

inka requested review of this revision.Jul 30 2024, 6:43 AM
tomek added inline comments.
native/tooltip/nux-tips-overlay.react.js
343–345 ↗(On Diff #42961)

This doesn't seem to do anything.

This revision is now accepted and ready to land.Jul 31 2024, 6:10 AM
native/tooltip/nux-tips-overlay.react.js
343–345 ↗(On Diff #42961)

This is removed in the next diff

Love the approach you took here of first copying the code, and then submitting a second diff to clear out the irrelevant stuff. It makes it much easier to review!