Page MenuHomePhabricator
Differential D13062

[native] Turn MenuComponent into text
ClosedPublic
Actions

Authored by inka on Aug 13 2024, 8:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Fri, Oct 18, 9:41 PM
Unknown Object (File)
Fri, Oct 18, 9:38 PM
Unknown Object (File)
Sep 20 2024, 12:05 AM
Unknown Object (File)
Sep 16 2024, 3:18 AM
Unknown Object (File)
Sep 16 2024, 3:18 AM
View All 55 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMMa59a69a40f8c: [native] Turn MenuComponent into text
Summary

issue: ENG-8914
We don't need to be passing a custom component

Test Plan

Rendered a tip:

Simulator Screenshot - iPhone 15 Pro - 2024-08-13 at 17.00.19.png (2×1 px, 311 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Aug 13 2024, 8:04 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 13 2024, 8:04 AM
inka added a parent revision: D12986: [native] Move render and constructor.Aug 13 2024, 8:04 AM
inka edited the test plan for this revision. (Show Details)
inka added inline comments.
native/tooltip/nux-tips-overlay.react.js
61–65 ↗(On Diff #43357)

These values will likely be updated later on

inka added a child revision: D13063: [native] Simplify name.Aug 13 2024, 8:06 AM
Harbormaster completed remote builds in B31071: Diff 43357.Aug 13 2024, 8:22 AM
inka requested review of this revision.Aug 13 2024, 8:22 AM
inka planned changes to this revision.Aug 13 2024, 8:31 AM

After second thoughts - this can just be a string

inka attached a referenced file: F2460671: Simulator Screenshot - iPhone 15 Pro - 2024-08-13 at 17.00.19.png. (Show Details)Aug 13 2024, 8:38 AM
inka updated this revision to Diff 43373.Aug 14 2024, 1:24 AM

Change text getter into string

inka retitled this revision from [native] Turn MenuComponent into text getter to [native] Turn MenuComponent into text.Aug 14 2024, 1:24 AM
Harbormaster completed remote builds in B31087: Diff 43373.Aug 14 2024, 1:40 AM
tomek accepted this revision.Aug 14 2024, 2:44 AM
This revision is now accepted and ready to land.Aug 14 2024, 2:44 AM
Closed by commit rCOMMa59a69a40f8c: [native] Turn MenuComponent into text (authored by inka). · Explain WhyAug 19 2024, 1:59 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMa59a69a40f8c: [native] Turn MenuComponent into text.

Revision Contents
Changeset List

PathSize
native/
tooltip/
11 lines

Diff 43436

View Options

native/tooltip/nux-tips-overlay.react.js

Loading...