Page MenuHomePhabricator
Differential D13154

[lib] start tracking progress of DM messages on `processDMOpsActionType` action
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 5:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 4:21 PM
Unknown Object (File)
Mon, Nov 25, 2:50 PM
Unknown Object (File)
Mon, Nov 25, 11:58 AM
Unknown Object (File)
Sun, Nov 24, 5:17 PM
Unknown Object (File)
Fri, Nov 22, 9:59 PM
Unknown Object (File)
Sat, Nov 9, 7:53 PM
Unknown Object (File)
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 2:29 AM
View All 42 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMba4eedc62ae3: [lib] start tracking progress of DM messages on `processDMOpsActionType` action
Summary

ENG-8423.

This is explained in code comments.

Depends on D13153

Test Plan

Check if text message has all outboundP2PMessages ids in LocalMessageInfo.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 23 2024, 5:38 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2024, 5:38 AM
kamil added a child revision: D13155: [lib] implement action for sending DM messages.Aug 23 2024, 5:42 AM
Harbormaster completed remote builds in B31238: Diff 43611.Aug 23 2024, 5:56 AM
kamil published this revision for review.Aug 23 2024, 7:26 AM
tomek accepted this revision.Aug 26 2024, 4:05 AM
tomek added inline comments.
lib/shared/dm-ops/process-dm-ops.js
169–170

I'm wondering if we should move this to the spec level. At least, we could have a function that takes the dm operation and returns an optional message ID for messageIDWithoutAutoRetry. But it seems we can go one step further, and more supportsAutoRetry entirely to the spec level. We would then have a coupling between supportsAutoRetry and the operation type.

This revision is now accepted and ready to land.Aug 26 2024, 4:05 AM
kamil mentioned this in D13169: [lib] add `supportsAutoRetry` to `DMOperationSpec`.Aug 26 2024, 7:03 AM
kamil updated this revision to Diff 43639.Aug 26 2024, 7:08 AM

rebase

kamil edited parent revisions, added: D13169: [lib] add `supportsAutoRetry` to `DMOperationSpec`; removed: D13153: [lib] add `outboundP2PMessageIDs` to `LocalMessageInfo` to track progress.Aug 26 2024, 7:09 AM
Harbormaster completed remote builds in B31264: Diff 43639.Aug 26 2024, 7:24 AM
Closed by commit rCOMMba4eedc62ae3: [lib] start tracking progress of DM messages on `processDMOpsActionType` action (authored by kamil). · Explain WhyAug 26 2024, 9:05 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMM0c797216d0f2: [lib] add `supportsAutoRetry` to `DMOperationSpec`.
kamil added a commit: rCOMMba4eedc62ae3: [lib] start tracking progress of DM messages on `processDMOpsActionType` action.

Revision Contents
Changeset List

PathSize
lib/
reducers/
52 lines
shared/
dm-ops/
12 lines
types/
4 lines

Diff 43611

View Options

lib/reducers/message-reducer.js

Loading...
View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/types/dm-ops.js

Loading...