Page MenuHomePhabricator
Differential D13177

[native] Create home tab tip
ClosedPublic
Actions

Authored by inka on Aug 27 2024, 8:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 2:31 PM
Unknown Object (File)
Wed, Apr 16, 12:31 AM
Unknown Object (File)
Tue, Apr 15, 10:50 PM
Unknown Object (File)
Tue, Apr 15, 10:07 PM
Unknown Object (File)
Tue, Apr 15, 3:08 PM
Unknown Object (File)
Feb 17 2025, 11:30 PM
Unknown Object (File)
Feb 17 2025, 11:30 PM
Unknown Object (File)
Feb 17 2025, 11:30 PM
View All 80 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMMe3d8a3f29e67: [native] Create home tab tip
Summary

issue: ENG-9063

Test Plan

Tested that it shows up after the community drawer tip and pressing ok navigates to the muted tab tip

Diff Detail

Repository
rCOMM Comm
Branch
inka/nux
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Aug 27 2024, 8:58 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2024, 8:58 AM
inka mentioned this in D13178: [native] Move ChatTabBarButton.Aug 27 2024, 8:59 AM
inka added a parent revision: D13178: [native] Move ChatTabBarButton.Aug 27 2024, 9:00 AM
Harbormaster completed remote builds in B31297: Diff 43698.Aug 27 2024, 9:15 AM
inka requested review of this revision.Aug 27 2024, 9:15 AM
inka added a child revision: D13179: [native] Make possible to render tip not pointing to anything.Aug 27 2024, 10:04 AM
tomek accepted this revision.Aug 28 2024, 3:56 AM
This revision is now accepted and ready to land.Aug 28 2024, 3:56 AM
inka updated this revision to Diff 43733.Aug 28 2024, 4:15 AM

Rebase

Harbormaster completed remote builds in B31325: Diff 43733.Aug 28 2024, 4:35 AM
Closed by commit rCOMMe3d8a3f29e67: [native] Create home tab tip (authored by inka). · Explain WhyAug 29 2024, 6:43 AM
This revision was automatically updated to reflect the committed changes.
inka mentioned this in rCOMM4434329e0518: [native] Move ChatTabBarButton.
inka added a commit: rCOMMe3d8a3f29e67: [native] Create home tab tip.

Revision Contents
Changeset List

PathSize
native/
components/
10 lines
navigation/
3 lines
22 lines
2 lines
3 lines

Diff 43698

View Options

native/components/nux-tips-context.react.js

// @flow // @flow
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js'; import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { import { defaultKeyserverInfo } from '../types/keyserver-types.js';
defaultKeyserverInfo,
type KeyserverStore,
} from '../types/keyserver-types.js';
import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
jest.mock('../utils/config.js'); jest.mock('../utils/config.js');
describe('reduceKeyserverStore', () => { describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => { it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = { const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
Show All 25 Lines it('removes from the store keyservers the user has disconnected from', () => {
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore, .keyserverStore,
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } }); ).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
}); });
it('update keyserverInfo with authoritativeKeyserverID', () => { it('update keyserverInfo with authoritativeKeyserverID', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 14 Lines expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual(null); ).toEqual(null);
}); });
it('return the same keyserverInfo with authoritativeKeyserverID()', () => { it('return the same keyserverInfo with authoritativeKeyserverID()', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 9 Lines const deleteAccountAction = {
customKeyName: undefined, customKeyName: undefined,
}, },
}; };
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual('blah'); ).toEqual('client_version_unsupported');
}); });
}); });
View Options

native/navigation/app-navigator.react.js

// @flow // @flow
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js'; import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { import { defaultKeyserverInfo } from '../types/keyserver-types.js';
defaultKeyserverInfo,
type KeyserverStore,
} from '../types/keyserver-types.js';
import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
jest.mock('../utils/config.js'); jest.mock('../utils/config.js');
describe('reduceKeyserverStore', () => { describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => { it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = { const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
Show All 25 Lines it('removes from the store keyservers the user has disconnected from', () => {
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore, .keyserverStore,
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } }); ).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
}); });
it('update keyserverInfo with authoritativeKeyserverID', () => { it('update keyserverInfo with authoritativeKeyserverID', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 14 Lines expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual(null); ).toEqual(null);
}); });
it('return the same keyserverInfo with authoritativeKeyserverID()', () => { it('return the same keyserverInfo with authoritativeKeyserverID()', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 9 Lines const deleteAccountAction = {
customKeyName: undefined, customKeyName: undefined,
}, },
}; };
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual('blah'); ).toEqual('client_version_unsupported');
}); });
}); });
View Options

native/navigation/home-tab-tip.react.js

// @flow // @flow
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js'; import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { import { defaultKeyserverInfo } from '../types/keyserver-types.js';
defaultKeyserverInfo,
type KeyserverStore,
} from '../types/keyserver-types.js';
import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
jest.mock('../utils/config.js'); jest.mock('../utils/config.js');
describe('reduceKeyserverStore', () => { describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => { it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = { const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
Show All 25 Lines it('removes from the store keyservers the user has disconnected from', () => {
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore, .keyserverStore,
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } }); ).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
}); });
it('update keyserverInfo with authoritativeKeyserverID', () => { it('update keyserverInfo with authoritativeKeyserverID', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 14 Lines expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual(null); ).toEqual(null);
}); });
it('return the same keyserverInfo with authoritativeKeyserverID()', () => { it('return the same keyserverInfo with authoritativeKeyserverID()', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 9 Lines const deleteAccountAction = {
customKeyName: undefined, customKeyName: undefined,
}, },
}; };
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual('blah'); ).toEqual('client_version_unsupported');
}); });
}); });
View Options

native/navigation/overlay-navigator.react.js

// @flow // @flow
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js'; import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { import { defaultKeyserverInfo } from '../types/keyserver-types.js';
defaultKeyserverInfo,
type KeyserverStore,
} from '../types/keyserver-types.js';
import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
jest.mock('../utils/config.js'); jest.mock('../utils/config.js');
describe('reduceKeyserverStore', () => { describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => { it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = { const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
Show All 25 Lines it('removes from the store keyservers the user has disconnected from', () => {
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore, .keyserverStore,
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } }); ).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
}); });
it('update keyserverInfo with authoritativeKeyserverID', () => { it('update keyserverInfo with authoritativeKeyserverID', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 14 Lines expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual(null); ).toEqual(null);
}); });
it('return the same keyserverInfo with authoritativeKeyserverID()', () => { it('return the same keyserverInfo with authoritativeKeyserverID()', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 9 Lines const deleteAccountAction = {
customKeyName: undefined, customKeyName: undefined,
}, },
}; };
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual('blah'); ).toEqual('client_version_unsupported');
}); });
}); });
View Options

native/navigation/route-names.js

Loading...