Page MenuHomePhabricator
Differential D13330

[web][native][lib] deprecate `sendDMActionTypes` and simplify hooks
ClosedPublic
Actions

Authored by kamil on Fri, Sep 13, 4:16 AM.
Tags
None
Referenced Files
F2741977: D13330.id44144.diff
Wed, Sep 18, 1:12 AM
F2741116: D13330.diff
Wed, Sep 18, 12:07 AM
Unknown Object (File)
Sun, Sep 15, 2:27 PM
Unknown Object (File)
Sat, Sep 14, 5:19 PM
Unknown Object (File)
Fri, Sep 13, 7:59 PM
Unknown Object (File)
Fri, Sep 13, 6:26 PM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
Unknown Object (File)
Fri, Sep 13, 8:43 AM
View All 9 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMMd83c2d52351f: [web][native][lib] deprecate `sendDMActionTypes` and simplify hooks
Summary

ENG-8424.

This removes code, now we use dedicated actions for composable messages. Some more context about why this is better in D13290.

Depends on D13329

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Sep 13, 4:16 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 13, 4:16 AM
kamil edited the summary of this revision. (Show Details)Fri, Sep 13, 4:17 AM
kamil added a parent revision: D13329: [web][native] update `InputStateContainer` logic for sending text messages.
kamil removed a parent revision: D13327: [lib] implement hook to send composable DMOperation.
kamil added a child revision: D13331: [lib] implement hook to send text multimedia message from `InputStateContainer`.Fri, Sep 13, 4:20 AM
Harbormaster completed remote builds in B31599: Diff 44144.Fri, Sep 13, 4:32 AM
kamil published this revision for review.Fri, Sep 13, 4:40 AM
tomek accepted this revision.Fri, Sep 13, 7:01 AM
This revision is now accepted and ready to land.Fri, Sep 13, 7:01 AM
kamil updated this revision to Diff 44211.Mon, Sep 16, 3:10 AM

rebase

kamil mentioned this in D13325: [lib] update `processOutboundP2PMessages` to return failed message IDs.Mon, Sep 16, 3:20 AM
Harbormaster completed remote builds in B31639: Diff 44211.Mon, Sep 16, 3:32 AM
Closed by commit rCOMMd83c2d52351f: [web][native][lib] deprecate `sendDMActionTypes` and simplify hooks (authored by kamil). · Explain WhyMon, Sep 16, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd83c2d52351f: [web][native][lib] deprecate `sendDMActionTypes` and simplify hooks.

Revision Contents
Changeset List

PathSize
lib/
reducers/
59 lines
shared/
dm-ops/
65 lines
types/
15 lines
18 lines
native/
chat/
21 lines
web/
chat/
20 lines

Diff 44225

View Options

lib/reducers/message-reducer.js

Loading...
View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/types/dm-ops.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/chat/failed-send.react.js

Loading...
View Options

web/chat/failed-send.react.js

Loading...