Page MenuHomePhabricator
Differential D13322

[lib] handle failed P2P messages when sending composable DM message
ClosedPublic
Actions

Authored by kamil on Fri, Sep 13, 3:25 AM.
Tags
None
Referenced Files
F2748443: D13322.id44129.diff
Wed, Sep 18, 10:23 AM
Unknown Object (File)
Tue, Sep 17, 3:48 PM
Unknown Object (File)
Tue, Sep 17, 9:39 AM
Unknown Object (File)
Sun, Sep 15, 6:49 PM
Unknown Object (File)
Fri, Sep 13, 11:36 AM
Unknown Object (File)
Fri, Sep 13, 10:20 AM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
Unknown Object (File)
Fri, Sep 13, 8:43 AM
View All 9 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM122966e5c4ac: [lib] handle failed P2P messages when sending composable DM message
Summary

ENG-8424.

Previously, it was implemented on sendDMActionTypes.success, but this was overcomplicated and will be removed.

Depends on D13321

Test Plan

Test dispatching action and make sure field is properly set.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Sep 13, 3:25 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 13, 3:25 AM
kamil added inline comments.Fri, Sep 13, 3:29 AM
lib/types/redux-types.js
727 ↗(On Diff #44128)

Here @ashoat suggested a different name, but I think it's readable enough because we use Outbound P2P messages only for thick thread DMs, but I can rename it, not feeling strongly

kamil added a child revision: D13323: [lib] rename `messageIDWithoutAutoRetry` -> `composableMessageID`.Fri, Sep 13, 3:33 AM
Harbormaster completed remote builds in B31590: Diff 44128.Fri, Sep 13, 3:42 AM
kamil published this revision for review.Fri, Sep 13, 4:33 AM
tomek accepted this revision.Fri, Sep 13, 6:02 AM
This revision is now accepted and ready to land.Fri, Sep 13, 6:02 AM
ashoat added inline comments.Sat, Sep 14, 9:14 AM
lib/types/redux-types.js
727 ↗(On Diff #44128)

I think adding "P2P" here is sufficient to avoid confusion :)

Closed by commit rCOMM122966e5c4ac: [lib] handle failed P2P messages when sending composable DM message (authored by kamil). · Explain WhyMon, Sep 16, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM122966e5c4ac: [lib] handle failed P2P messages when sending composable DM message.

Revision Contents
Changeset List

PathSize
lib/
reducers/
18 lines
types/
2 lines

Diff 44217

View Options

lib/reducers/message-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...