Page MenuHomePhabricator
Differential D13329

[web][native] update `InputStateContainer` logic for sending text messages
ClosedPublic
Actions

Authored by kamil on Fri, Sep 13, 4:12 AM.
Tags
None
Referenced Files
F2742262: D13329.id44143.diff
Wed, Sep 18, 1:31 AM
Unknown Object (File)
Tue, Sep 17, 1:27 PM
Unknown Object (File)
Sun, Sep 15, 6:29 PM
Unknown Object (File)
Fri, Sep 13, 3:36 PM
Unknown Object (File)
Fri, Sep 13, 11:22 AM
Unknown Object (File)
Fri, Sep 13, 8:57 AM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
View All 9 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM303c9c123089: [web][native] update `InputStateContainer` logic for sending text messages
Summary

ENG-8424.

This makes updates code to use one hook on both platforms which handles both thick and thin threads, and avoids hacking logic on both InputStateContainer implementations.

Depends on D13328

Test Plan

Tested end-to-end according to the process described here.

Additionally, tested creating threads and sidebars.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Sep 13, 4:12 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 13, 4:12 AM
Harbormaster failed remote builds in B31598: Diff 44143!Fri, Sep 13, 4:16 AM
kamil added a child revision: D13330: [web][native][lib] deprecate `sendDMActionTypes` and simplify hooks.Fri, Sep 13, 4:17 AM
kamil edited the test plan for this revision. (Show Details)Fri, Sep 13, 4:22 AM
Harbormaster completed remote builds in B31598: Diff 44143.Fri, Sep 13, 4:37 AM
kamil published this revision for review.Fri, Sep 13, 4:40 AM
kamil edited the summary of this revision. (Show Details)
tomek accepted this revision.Fri, Sep 13, 6:57 AM
This revision is now accepted and ready to land.Fri, Sep 13, 6:57 AM
kamil updated this revision to Diff 44210.Mon, Sep 16, 3:08 AM

rebase

Harbormaster completed remote builds in B31638: Diff 44210.Mon, Sep 16, 3:28 AM
Closed by commit rCOMM303c9c123089: [web][native] update `InputStateContainer` logic for sending text messages (authored by kamil). · Explain WhyMon, Sep 16, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM303c9c123089: [web][native] update `InputStateContainer` logic for sending text messages.
kamil mentioned this in D13334: Call textMessageCreationSideEffectsFunc after sending DM text message.Tue, Sep 17, 12:50 AM

Revision Contents
Changeset List

PathSize
native/
input/
131 lines
web/
input/
132 lines

Diff 44224

View Options

native/input/input-state-container.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...