Page MenuHomePhabricator
Differential D13331

[lib] implement hook to send text multimedia message from `InputStateContainer`
ClosedPublic
Actions

Authored by kamil on Sep 13 2024, 4:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 2:01 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:56 PM
Unknown Object (File)
Sat, Oct 19, 1:29 AM
Unknown Object (File)
Sat, Oct 19, 1:27 AM
Unknown Object (File)
Wed, Oct 16, 7:57 AM
View All 40 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
bartek
Commits
rCOMM426bf8ac3298: [lib] implement hook to send text multimedia message from `InputStateContainer`
Summary

ENG-8424.

One hook to send multimedia message for both thick and thin threads and for both web and native.

Depends on D13330

Test Plan

Tested in text diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Sep 13 2024, 4:20 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 4:20 AM
kamil added a child revision: D13332: [web][native] update `InputStateContainer` logic for sending multimedia messages.Sep 13 2024, 4:27 AM
Harbormaster completed remote builds in B31600: Diff 44145.Sep 13 2024, 4:37 AM
kamil published this revision for review.Sep 13 2024, 4:41 AM
kamil added inline comments.
lib/hooks/input-state-container-hooks.js
200 ↗(On Diff #44145)

same concern as here: https://phab.comm.dev/D13328#inline-76652

bartek accepted this revision.Sep 13 2024, 6:57 AM
bartek added inline comments.
lib/hooks/input-state-container-hooks.js
200 ↗(On Diff #44145)

I guess the only way is to create a custom class in lib/utils/errors.js

This revision is now accepted and ready to land.Sep 13 2024, 6:57 AM
tomek accepted this revision.Sep 13 2024, 7:08 AM
kamil updated this revision to Diff 44212.Sep 16 2024, 3:13 AM

rebase

Harbormaster failed remote builds in B31640: Diff 44212!Sep 16 2024, 3:17 AM
kamil added inline comments.Sep 16 2024, 3:27 AM
lib/hooks/input-state-container-hooks.js
200 ↗(On Diff #44145)

created ENG-9277

Harbormaster completed remote builds in B31640: Diff 44212.Sep 16 2024, 3:36 AM
Closed by commit rCOMM426bf8ac3298: [lib] implement hook to send text multimedia message from `InputStateContainer` (authored by kamil). · Explain WhySep 16 2024, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM426bf8ac3298: [lib] implement hook to send text multimedia message from `InputStateContainer`.

Revision Contents
Changeset List

PathSize
lib/
hooks/
125 lines

Diff 44226

View Options

lib/hooks/input-state-container-hooks.js

Loading...