[lib] implement hook to send composable DMOperation
ClosedPublic
Actions

Authored by kamil on Sep 13 2024, 4:00 AM.

Details

Reviewers

tomek
inka

Commits

rCOMMbbee043fc478: [lib] implement hook to send composable DMOperation

Summary

ENG-8424.

Improve documenting code and addresses https://phab.comm.dev/D13290#inline-76570, we have a separate and clear hook for composable messages. This will replace some of the code, which is removed later in the stack.

Depends on D13326

Test Plan

Tested later in the stack (both content and notifs)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 13 2024, 4:00 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 4:00 AM

kamil added a child revision: D13328: [lib] implement hook to send text message from `InputStateContainer.Sep 13 2024, 4:05 AM

kamil added a child revision: D13330: [web][native][lib] deprecate `sendDMActionTypes` and simplify hooks.Sep 13 2024, 4:16 AM

kamil removed a child revision: D13330: [web][native][lib] deprecate `sendDMActionTypes` and simplify hooks.Sep 13 2024, 4:17 AM

Harbormaster completed remote builds in B31595: Diff 44140.Sep 13 2024, 4:17 AM

kamil published this revision for review.Sep 13 2024, 4:38 AM

kamil edited the test plan for this revision. (Show Details)

kamil added inline comments.

lib/shared/dm-ops/process-dm-ops.js
387–393 ↗	(On Diff #44140)	this is duplicated, can be moved to a separate hook but not sure if worth

tomek accepted this revision.Sep 13 2024, 6:39 AM

tomek added inline comments.

lib/shared/dm-ops/process-dm-ops.js
387–393 ↗	(On Diff #44140)	I guess we can create `useSendDMOperationUtils` hook.
399–429 ↗	(On Diff #44140)	We're relying on the `started` actions to do all the work so that we don't need to process the operations here. However, one missing part is updating the reply count for thick sidebars. For thin threads, the keyserver is responsible for updating it and we probably need to introduce this logic to our reducers.