Page MenuHomePhabricator
Differential D13324

[lib] update `processDMOpsActionType` to handle composable DM messages
ClosedPublic
Actions

Authored by kamil on Fri, Sep 13, 3:40 AM.
Tags
None
Referenced Files
F2737494: D13324.diff
Tue, Sep 17, 6:52 PM
Unknown Object (File)
Mon, Sep 16, 12:17 PM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
Unknown Object (File)
Fri, Sep 13, 8:43 AM
Unknown Object (File)
Fri, Sep 13, 8:43 AM
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM5095574803af: [lib] update `processDMOpsActionType` to handle composable DM messages
Summary

ENG-8424.

Previously it was done using sendDMActionTypes.started - but this code will be removed later in the stack.

Depends on D13323

Test Plan

Tested, that only when sending text message outboundP2PMessageIDs is set, and failed messages are persisted.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Sep 13, 3:40 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 13, 3:40 AM
kamil added a child revision: D13325: [lib] update `processOutboundP2PMessages` to return failed message IDs.Fri, Sep 13, 3:43 AM
Harbormaster completed remote builds in B31592: Diff 44137.Fri, Sep 13, 3:57 AM
kamil published this revision for review.Fri, Sep 13, 4:34 AM
kamil added inline comments.
lib/reducers/message-reducer.js
1926 ↗(On Diff #44137)
tomek accepted this revision.Fri, Sep 13, 6:14 AM
tomek added inline comments.
lib/reducers/message-reducer.js
1908–1909 ↗(On Diff #44137)

Do we still need to keep these two conditions?

This revision is now accepted and ready to land.Fri, Sep 13, 6:14 AM
kamil added inline comments.Mon, Sep 16, 3:00 AM
lib/reducers/message-reducer.js
1908–1909 ↗(On Diff #44137)

yeah, otherwise Flow complains

kamil updated this revision to Diff 44206.Mon, Sep 16, 3:00 AM

fix comment

Harbormaster completed remote builds in B31634: Diff 44206.Mon, Sep 16, 3:16 AM
Closed by commit rCOMM5095574803af: [lib] update `processDMOpsActionType` to handle composable DM messages (authored by kamil). · Explain WhyMon, Sep 16, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM5095574803af: [lib] update `processDMOpsActionType` to handle composable DM messages.

Revision Contents
Changeset List

PathSize
lib/
reducers/
21 lines

Diff 44218

View Options

lib/reducers/message-reducer.js

Loading...