[lib] rename `messageIDWithoutAutoRetry` -> `composableMessageID`
ClosedPublic
Actions

Authored by kamil on Sep 13 2024, 10:33 AM.

Details

Reviewers

tomek
inka

Commits

rCOMM037accb53aa2: [lib] rename `messageIDWithoutAutoRetry` -> `composableMessageID`

Summary

ENG-8424.

Improve naming and addresses https://phab.comm.dev/D13290#inline-76565.

Depends on D13322

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 13 2024, 10:33 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 10:33 AM

kamil added a child revision: D13324: [lib] update `processDMOpsActionType` to handle composable DM messages.Sep 13 2024, 10:40 AM

Harbormaster completed remote builds in B31591: Diff 44129.Sep 13 2024, 10:54 AM

kamil published this revision for review.Sep 13 2024, 11:33 AM

tomek accepted this revision.Sep 13 2024, 1:03 PM

This revision is now accepted and ready to land.Sep 13 2024, 1:03 PM

Thanks for doing this!

Closed by commit rCOMM037accb53aa2: [lib] rename `messageIDWithoutAutoRetry` -> `composableMessageID`. · Explain WhySep 16 2024, 11:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM037accb53aa2: [lib] rename `messageIDWithoutAutoRetry` -> `composableMessageID`.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

9 lines

shared/

dm-ops/

process-dm-ops.js

8 lines

types/

dm-ops.js

2 lines

Diff 44219

View Options

lib/reducers/message-reducer.js

View Options

lib/shared/dm-ops/process-dm-ops.js

View Options

[lib] rename `messageIDWithoutAutoRetry` -> `composableMessageID`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44219

lib/reducers/message-reducer.js

lib/shared/dm-ops/process-dm-ops.js

lib/types/dm-ops.js

[lib] rename `messageIDWithoutAutoRetry` -> `composableMessageID`
ClosedPublic
Actions

Revision Contents
Changeset List