Page MenuHomePhabricator
Differential D13351

[lib] update `processOutboundP2PMessages` return type
ClosedPublic
Actions

Authored by kamil on Sep 16 2024, 3:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 5:14 AM
Unknown Object (File)
Fri, Apr 4, 12:03 AM
Unknown Object (File)
Wed, Apr 2, 11:42 AM
Unknown Object (File)
Wed, Apr 2, 2:01 AM
Unknown Object (File)
Tue, Apr 1, 9:38 PM
Unknown Object (File)
Mon, Mar 31, 9:18 PM
Unknown Object (File)
Tue, Mar 25, 8:21 AM
Unknown Object (File)
Mar 6 2025, 7:22 AM
View All 57 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM23686a4ec811: [lib] update `processOutboundP2PMessages` return type
Summary

ENG-8424.

Addresses https://phab.comm.dev/D13325#inline-76680.

Depends on D13332

Test Plan

Repeat test plan from D13325

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
hooks/
12 lines
shared/
dm-ops/
9 lines
tunnelbroker/
51 lines

Diff 44228

View Options

lib/hooks/input-state-container-hooks.js

  • This file was added.
// @flow
import type {
DMOperationSpec,
ProcessDMOperationUtilities,
} from './dm-op-spec.js';
import type { DMSendMultimediaMessageOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js';
import type { MediaMessageData } from '../../types/messages/media.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js';
function createMessageDataFromDMOperation(
dmOperation: DMSendMultimediaMessageOperation,
): MediaMessageData {
const { threadID, creatorID, time, media } = dmOperation;
return {
type: messageTypes.MULTIMEDIA,
threadID,
creatorID,
time,
media,
};
}
const sendMultimediaMessageSpec: DMOperationSpec<DMSendMultimediaMessageOperation> =
Object.freeze({
notificationsCreationData: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const messageData = createMessageDataFromDMOperation(dmOperation);
return { messageDatas: [messageData] };
},
processDMOperation: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const { messageID } = dmOperation;
const messageData = createMessageDataFromDMOperation(dmOperation);
const rawMessageInfos = [
rawMessageInfoFromMessageData(messageData, messageID),
];
const updateInfos: Array<ClientUpdateInfo> = [];
return {
rawMessageInfos,
updateInfos,
};
},
canBeProcessed(
dmOperation: DMSendMultimediaMessageOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) {
if (utilities.threadInfos[dmOperation.threadID]) {
return { isProcessingPossible: true };
}
return {
isProcessingPossible: false,
reason: {
type: 'missing_thread',
threadID: dmOperation.threadID,
},
};
},
supportsAutoRetry: false,
});
export { sendMultimediaMessageSpec };
View Options

lib/shared/dm-ops/process-dm-ops.js

  • This file was added.
// @flow
import type {
DMOperationSpec,
ProcessDMOperationUtilities,
} from './dm-op-spec.js';
import type { DMSendMultimediaMessageOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js';
import type { MediaMessageData } from '../../types/messages/media.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js';
function createMessageDataFromDMOperation(
dmOperation: DMSendMultimediaMessageOperation,
): MediaMessageData {
const { threadID, creatorID, time, media } = dmOperation;
return {
type: messageTypes.MULTIMEDIA,
threadID,
creatorID,
time,
media,
};
}
const sendMultimediaMessageSpec: DMOperationSpec<DMSendMultimediaMessageOperation> =
Object.freeze({
notificationsCreationData: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const messageData = createMessageDataFromDMOperation(dmOperation);
return { messageDatas: [messageData] };
},
processDMOperation: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const { messageID } = dmOperation;
const messageData = createMessageDataFromDMOperation(dmOperation);
const rawMessageInfos = [
rawMessageInfoFromMessageData(messageData, messageID),
];
const updateInfos: Array<ClientUpdateInfo> = [];
return {
rawMessageInfos,
updateInfos,
};
},
canBeProcessed(
dmOperation: DMSendMultimediaMessageOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) {
if (utilities.threadInfos[dmOperation.threadID]) {
return { isProcessingPossible: true };
}
return {
isProcessingPossible: false,
reason: {
type: 'missing_thread',
threadID: dmOperation.threadID,
},
};
},
supportsAutoRetry: false,
});
export { sendMultimediaMessageSpec };
View Options

lib/tunnelbroker/peer-to-peer-context.js

  • This file was added.
// @flow
import type {
DMOperationSpec,
ProcessDMOperationUtilities,
} from './dm-op-spec.js';
import type { DMSendMultimediaMessageOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js';
import type { MediaMessageData } from '../../types/messages/media.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js';
function createMessageDataFromDMOperation(
dmOperation: DMSendMultimediaMessageOperation,
): MediaMessageData {
const { threadID, creatorID, time, media } = dmOperation;
return {
type: messageTypes.MULTIMEDIA,
threadID,
creatorID,
time,
media,
};
}
const sendMultimediaMessageSpec: DMOperationSpec<DMSendMultimediaMessageOperation> =
Object.freeze({
notificationsCreationData: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const messageData = createMessageDataFromDMOperation(dmOperation);
return { messageDatas: [messageData] };
},
processDMOperation: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const { messageID } = dmOperation;
const messageData = createMessageDataFromDMOperation(dmOperation);
const rawMessageInfos = [
rawMessageInfoFromMessageData(messageData, messageID),
];
const updateInfos: Array<ClientUpdateInfo> = [];
return {
rawMessageInfos,
updateInfos,
};
},
canBeProcessed(
dmOperation: DMSendMultimediaMessageOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) {
if (utilities.threadInfos[dmOperation.threadID]) {
return { isProcessingPossible: true };
}
return {
isProcessingPossible: false,
reason: {
type: 'missing_thread',
threadID: dmOperation.threadID,
},
};
},
supportsAutoRetry: false,
});
export { sendMultimediaMessageSpec };