Page MenuHomePhabricator
Differential D13332

[web][native] update `InputStateContainer` logic for sending multimedia messages
ClosedPublic
Actions

Authored by kamil on Fri, Sep 13, 4:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 17, 12:28 PM
Unknown Object (File)
Tue, Sep 17, 2:45 AM
Unknown Object (File)
Mon, Sep 16, 2:36 AM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
Unknown Object (File)
Fri, Sep 13, 8:43 AM
Subscribers
ashoat

Details

Reviewers
tomek
inka
bartek
Commits
rCOMM2c56d0e0280a: [web][native] update `InputStateContainer` logic for sending multimedia messages
Summary

ENG-8424.

This makes updates code to use one hok on both platforms which handles both thick and thin threads, avoids hacking logic on both InputStateContainer.

Depends on D13331

Test Plan
  1. Sending multimedia.
  2. Multimedia statuses.
  3. Multimedia retries.
  4. Creating thread where first message is multimedia.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Sep 13, 4:27 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 13, 4:27 AM
kamil mentioned this in D13319: [lib] DMOperationSpec for multimedia message.Fri, Sep 13, 4:28 AM
kamil published this revision for review.Fri, Sep 13, 4:42 AM
Harbormaster completed remote builds in B31604: Diff 44149.Fri, Sep 13, 4:50 AM
bartek accepted this revision.Fri, Sep 13, 6:19 AM
bartek added inline comments.
web/input/input-state-container.react.js
540–543 ↗(On Diff #44149)

Is this still used anywhere in this func? I see you moved this into the useInputStateContainerSendMultimediaMessage() hook in the previous diff

This revision is now accepted and ready to land.Fri, Sep 13, 6:19 AM
tomek accepted this revision.Fri, Sep 13, 7:10 AM
tomek added inline comments.
web/input/input-state-container.react.js
548 ↗(On Diff #44149)

What does it mean to be a legacy? Are we planning to update the approach?

bartek added inline comments.Fri, Sep 13, 10:47 AM
web/input/input-state-container.react.js
548 ↗(On Diff #44149)

We have two ways of calling the create_multimedia_message keyserver endpoint:

  • the new one which accepts mediaMessageContents - used on native, according to D5127 and D5191 it also supports videos
  • the "legacy" one which accepts mediaIDs - used on web

I guess we'll stop using the legacy one when we implement video uploads for web

kamil updated this revision to Diff 44213.Mon, Sep 16, 3:14 AM

rebase

kamil added a child revision: D13351: [lib] update `processOutboundP2PMessages` return type.Mon, Sep 16, 3:16 AM
Harbormaster completed remote builds in B31641: Diff 44213.Mon, Sep 16, 3:42 AM
Closed by commit rCOMM2c56d0e0280a: [web][native] update `InputStateContainer` logic for sending multimedia messages (authored by kamil). · Explain WhyMon, Sep 16, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMMc0173168346c: [lib] DMOperationSpec for multimedia message.
kamil added a commit: rCOMM2c56d0e0280a: [web][native] update `InputStateContainer` logic for sending multimedia messages.

Revision Contents
Changeset List

PathSize
native/
input/
37 lines
web/
input/
39 lines

Diff 44227

View Options

native/input/input-state-container.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...