Page MenuHomePhabricator
Differential D13332

[web][native] update `InputStateContainer` logic for sending multimedia messages
ClosedPublic
Actions

Authored by kamil on Sep 13 2024, 4:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 5:10 AM
Unknown Object (File)
Sun, Nov 24, 2:01 PM
Unknown Object (File)
Nov 20 2024, 11:08 AM
Unknown Object (File)
Nov 20 2024, 11:08 AM
Unknown Object (File)
Nov 14 2024, 1:02 PM
Unknown Object (File)
Nov 14 2024, 12:59 PM
Unknown Object (File)
Oct 20 2024, 2:58 PM
Unknown Object (File)
Oct 20 2024, 2:58 PM
View All 45 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
bartek
Commits
rCOMM2c56d0e0280a: [web][native] update `InputStateContainer` logic for sending multimedia messages
Summary

ENG-8424.

This makes updates code to use one hok on both platforms which handles both thick and thin threads, avoids hacking logic on both InputStateContainer.

Depends on D13331

Test Plan
  1. Sending multimedia.
  2. Multimedia statuses.
  3. Multimedia retries.
  4. Creating thread where first message is multimedia.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Sep 13 2024, 4:27 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 4:27 AM
kamil mentioned this in D13319: [lib] DMOperationSpec for multimedia message.Sep 13 2024, 4:28 AM
kamil published this revision for review.Sep 13 2024, 4:42 AM
Harbormaster completed remote builds in B31604: Diff 44149.Sep 13 2024, 4:50 AM
bartek accepted this revision.Sep 13 2024, 6:19 AM
bartek added inline comments.
web/input/input-state-container.react.js
540–543 ↗(On Diff #44149)

Is this still used anywhere in this func? I see you moved this into the useInputStateContainerSendMultimediaMessage() hook in the previous diff

This revision is now accepted and ready to land.Sep 13 2024, 6:19 AM
tomek accepted this revision.Sep 13 2024, 7:10 AM
tomek added inline comments.
web/input/input-state-container.react.js
548 ↗(On Diff #44149)

What does it mean to be a legacy? Are we planning to update the approach?

bartek added inline comments.Sep 13 2024, 10:47 AM
web/input/input-state-container.react.js
548 ↗(On Diff #44149)

We have two ways of calling the create_multimedia_message keyserver endpoint:

  • the new one which accepts mediaMessageContents - used on native, according to D5127 and D5191 it also supports videos
  • the "legacy" one which accepts mediaIDs - used on web

I guess we'll stop using the legacy one when we implement video uploads for web

kamil updated this revision to Diff 44213.Sep 16 2024, 3:14 AM

rebase

kamil added a child revision: D13351: [lib] update `processOutboundP2PMessages` return type.Sep 16 2024, 3:16 AM
Harbormaster completed remote builds in B31641: Diff 44213.Sep 16 2024, 3:42 AM
Closed by commit rCOMM2c56d0e0280a: [web][native] update `InputStateContainer` logic for sending multimedia messages (authored by kamil). · Explain WhySep 16 2024, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMMc0173168346c: [lib] DMOperationSpec for multimedia message.
kamil added a commit: rCOMM2c56d0e0280a: [web][native] update `InputStateContainer` logic for sending multimedia messages.

Revision Contents
Changeset List

PathSize
native/
input/
37 lines
web/
input/
39 lines

Diff 44227

View Options

native/input/input-state-container.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...