[web][native] update `InputStateContainer` logic for sending multimedia messages
ClosedPublic
Actions

Authored by kamil on Sep 13 2024, 11:27 AM.

Details

Reviewers

Commits

Summary

This makes updates code to use one hok on both platforms which handles both thick and thin threads, avoids hacking logic on both InputStateContainer.

Depends on D13331

Test Plan

Repository

rCOMM Comm

Branch

publish

Lint

No Lint Coverage

Unit

No Test Coverage

kamil held this revision as a draft.

kamil published this revision for review.Sep 13 2024, 11:42 AM

bartek added inline comments.

web/input/input-state-container.react.js
540–543	Is this still used anywhere in this func? I see you moved this into the `useInputStateContainerSendMultimediaMessage()` hook in the previous diff

This revision is now accepted and ready to land.Sep 13 2024, 1:19 PM

tomek added inline comments.

web/input/input-state-container.react.js
548	What does it mean to be a legacy? Are we planning to update the approach?

web/input/input-state-container.react.js
548	We have two ways of calling the `create_multimedia_message` keyserver endpoint: the new one which accepts `mediaMessageContents` - used on native, according to D5127 and D5191 it also supports videos the "legacy" one which accepts `mediaIDs` - used on web I guess we'll stop using the legacy one when we implement video uploads for web