Page MenuHomePhabricator
Differential D13328

[lib] implement hook to send text message from `InputStateContainer
ClosedPublic
Actions

Authored by kamil on Fri, Sep 13, 4:05 AM.
Tags
None
Referenced Files
F2753578: D13328.id44141.diff
Wed, Sep 18, 5:40 PM
F2753397: D13328.id44209.diff
Wed, Sep 18, 5:31 PM
F2753385: D13328.id.diff
Wed, Sep 18, 5:27 PM
F2752406: D13328.id44223.diff
Wed, Sep 18, 4:00 PM
F2750481: D13328.id44209.diff
Wed, Sep 18, 1:26 PM
Unknown Object (File)
Mon, Sep 16, 9:25 AM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
View All 9 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMb262440cd963: [lib] implement hook to send text message from `InputStateContainer
Summary

ENG-8424.

This code will handle both thick and thin threads, this is the point where we diverge logic, not in InputStateContainer on web and native.

Depends on D13327

Test Plan

Tested later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Sep 13, 4:05 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 13, 4:05 AM
kamil added inline comments.Fri, Sep 13, 4:06 AM
lib/hooks/input-state-container-hooks.js
74–76 ↗(On Diff #44141)
85–89 ↗(On Diff #44141)

not sure what is a better way of handling this without any

kamil added a child revision: D13329: [web][native] update `InputStateContainer` logic for sending text messages.Fri, Sep 13, 4:12 AM
Harbormaster completed remote builds in B31596: Diff 44141.Fri, Sep 13, 4:22 AM
kamil published this revision for review.Fri, Sep 13, 4:39 AM
kamil mentioned this in D13331: [lib] implement hook to send text multimedia message from `InputStateContainer`.Fri, Sep 13, 4:41 AM
tomek accepted this revision.Fri, Sep 13, 6:53 AM
tomek added inline comments.
lib/hooks/input-state-container-hooks.js
85–89 ↗(On Diff #44141)

Can we use our ExtendableError?

This revision is now accepted and ready to land.Fri, Sep 13, 6:53 AM
kamil updated this revision to Diff 44209.Mon, Sep 16, 3:06 AM
  • rebase
  • fix comment
Harbormaster completed remote builds in B31637: Diff 44209.Mon, Sep 16, 3:24 AM
kamil added inline comments.Mon, Sep 16, 3:27 AM
lib/hooks/input-state-container-hooks.js
85–89 ↗(On Diff #44141)

created ENG-9277

Closed by commit rCOMMb262440cd963: [lib] implement hook to send text message from `InputStateContainer (authored by kamil). · Explain WhyMon, Sep 16, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMb262440cd963: [lib] implement hook to send text message from `InputStateContainer.

Revision Contents
Changeset List

PathSize
lib/
hooks/
100 lines

Diff 44223

View Options

lib/hooks/input-state-container-hooks.js

Loading...