[lib] delete `CallSingleKeyserverEndpointResultInfoInterface`
ClosedPublic
Actions

Authored by kamil on Sep 13 2024, 3:18 AM.

Details

Reviewers

tomek
inka
ashoat

Commits

rCOMM210ac5cd8efd: [lib] delete `CallSingleKeyserverEndpointResultInfoInterface`

Summary

ENG-8424.

Later in the stack, we need to return SendMessagePayload (which has +interface: CallSingleKeyserverEndpointResultInfoInterface) as a result of DM Ops. which is encrypting and queueing messages on Tunnelbroker, not keyserver call.

Alternatives:

Use tunnelbroker instead of none - I think this is even worse for readability because the type is associated with Keyserver.
Remove interface from SendMessagePayload - this seems the best and I think it's safe because I wasn't able to find any usage of interface.

I am not familiar with why we need this at all, so curious about the reviewers' perspective.

Depends on D13319

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 13 2024, 3:18 AM

kamil held this revision as a draft.

kamil added a child revision: D13322: [lib] handle failed P2P messages when sending composable DM message.Sep 13 2024, 3:25 AM

Harbormaster completed remote builds in B31589: Diff 44126.Sep 13 2024, 3:34 AM

kamil published this revision for review.Sep 13 2024, 4:33 AM

kamil edited the summary of this revision. (Show Details)

tomek accepted this revision.Sep 13 2024, 6:00 AM

This revision is now accepted and ready to land.Sep 13 2024, 6:00 AM

Remove interface from SendMessagePayload - this seems the best and I think it's safe because I wasn't able to find any usage of interface.

I am not familiar with why we need this at all, so curious about the reviewers' perspective.

I think @tomek did some research on this in D6151:

I was curious about why do we need this field. Is it used anywhere?

I've searched a bit and it seems like this field was introduced in D511 and then the usage was removed in D4645, so maybe we don't need this field at all. It doesn't hurt to keep it for some time, though.

I did some additional research and I also don't think there are any uses of this field anymore. I think it would be safe to delete.

remove interface

kamil retitled this revision from [lib] update `CallSingleKeyserverEndpointResultInfoInterface` to handle `none` to [lib] delete `CallSingleKeyserverEndpointResultInfoInterface`.Sep 16 2024, 2:57 AM

tomek accepted this revision.Sep 16 2024, 3:13 AM

Harbormaster completed remote builds in B31633: Diff 44205.Sep 16 2024, 3:14 AM

Closed by commit rCOMM210ac5cd8efd: [lib] delete `CallSingleKeyserverEndpointResultInfoInterface` (authored by kamil). · Explain WhySep 16 2024, 4:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM210ac5cd8efd: [lib] delete `CallSingleKeyserverEndpointResultInfoInterface`.