Tags

None

Referenced Files

	F3513828: D13326.diff
	Sun, Dec 22, 2:24 AM

	Unknown Object (File)
	Mon, Dec 16, 5:10 AM

	Unknown Object (File)
	Wed, Dec 4, 7:08 PM

	Unknown Object (File)
	Fri, Nov 29, 11:20 AM

	Unknown Object (File)
	Tue, Nov 26, 6:00 AM

	Unknown Object (File)
	Tue, Nov 26, 12:26 AM

	Unknown Object (File)
	Mon, Nov 25, 9:23 PM

	Unknown Object (File)
	Nov 20 2024, 11:08 AM

View All 51 Files

Subscribers

ashoat

Details

Reviewers

tomek
inka

Commits

rCOMM27939ee763b5: [lib] introduce type for composable DMOperation

Summary

ENG-8424.

Improve documenting code and addresses https://phab.comm.dev/D13290#inline-76570.

Depends on D13325

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 13 2024, 3:55 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 3:55 AM

kamil added a child revision: D13327: [lib] implement hook to send composable DMOperation.Sep 13 2024, 4:00 AM

Harbormaster completed remote builds in B31594: Diff 44139.Sep 13 2024, 4:12 AM

kamil published this revision for review.Sep 13 2024, 4:35 AM

tomek accepted this revision.Sep 13 2024, 6:24 AM

tomek added inline comments.

lib/shared/dm-ops/dm-op-utils.js
72 ↗	(On Diff #44139)	This needs to be rebased.

This revision is now accepted and ready to land.Sep 13 2024, 6:24 AM

rebase

Harbormaster completed remote builds in B31635: Diff 44207.Sep 16 2024, 3:18 AM

Closed by commit rCOMM27939ee763b5: [lib] introduce type for composable DMOperation (authored by kamil). · Explain WhySep 16 2024, 4:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM27939ee763b5: [lib] introduce type for composable DMOperation.

[lib] introduce type for composable DMOperation
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 44221

lib/shared/dm-ops/dm-op-utils.js

lib/types/dm-ops.js

[lib] introduce type for composable DMOperationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44221

lib/shared/dm-ops/dm-op-utils.js

lib/types/dm-ops.js

[lib] introduce type for composable DMOperation
ClosedPublic
Actions

Revision Contents
Changeset List