[lib] introduce type for composable DMOperation
ClosedPublic
Actions

Authored by kamil on Sep 13 2024, 10:55 AM.

Details

Reviewers

tomek
inka

Commits

rCOMM27939ee763b5: [lib] introduce type for composable DMOperation

Summary

ENG-8424.

Improve documenting code and addresses https://phab.comm.dev/D13290#inline-76570.

Depends on D13325

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 13 2024, 10:55 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 10:55 AM

kamil added a child revision: D13327: [lib] implement hook to send composable DMOperation.Sep 13 2024, 11:00 AM

Harbormaster completed remote builds in B31594: Diff 44139.Sep 13 2024, 11:12 AM

kamil published this revision for review.Sep 13 2024, 11:35 AM

tomek accepted this revision.Sep 13 2024, 1:24 PM

tomek added inline comments.

lib/shared/dm-ops/dm-op-utils.js
72 ↗	(On Diff #44139)	This needs to be rebased.

This revision is now accepted and ready to land.Sep 13 2024, 1:24 PM

rebase

Harbormaster completed remote builds in B31635: Diff 44207.Sep 16 2024, 10:18 AM

Closed by commit rCOMM27939ee763b5: [lib] introduce type for composable DMOperation. · Explain WhySep 16 2024, 11:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM27939ee763b5: [lib] introduce type for composable DMOperation.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

dm-op-utils.js

23 lines

types/

dm-ops.js

4 lines

Diff 44221

View Options

lib/shared/dm-ops/dm-op-utils.js