Page MenuHomePhabricator

[lib] implement hook to send composable DMOperation
ClosedPublic

Authored by kamil on Sep 13 2024, 4:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:56 PM
Unknown Object (File)
Fri, Oct 18, 1:09 PM
Unknown Object (File)
Tue, Oct 15, 1:22 AM
Unknown Object (File)
Mon, Oct 14, 2:29 PM
Unknown Object (File)
Sun, Oct 13, 7:12 PM
Subscribers

Details

Summary

ENG-8424.

Improve documenting code and addresses https://phab.comm.dev/D13290#inline-76570, we have a separate and clear hook for composable messages. This will replace some of the code, which is removed later in the stack.

Depends on D13326

Test Plan

Tested later in the stack (both content and notifs)

Diff Detail

Repository
rCOMM Comm
Branch
publish
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Sep 13 2024, 4:38 AM
kamil edited the test plan for this revision. (Show Details)
kamil added inline comments.
lib/shared/dm-ops/process-dm-ops.js
387–393

this is duplicated, can be moved to a separate hook but not sure if worth

tomek added inline comments.
lib/shared/dm-ops/process-dm-ops.js
387–393

I guess we can create useSendDMOperationUtils hook.

399–429

We're relying on the started actions to do all the work so that we don't need to process the operations here. However, one missing part is updating the reply count for thick sidebars. For thin threads, the keyserver is responsible for updating it and we probably need to introduce this logic to our reducers.

This revision is now accepted and ready to land.Sep 13 2024, 6:39 AM
  • rebase
  • create a hook
lib/shared/dm-ops/process-dm-ops.js
399–429

Tracked in ENG-9273.