Page MenuHomePhabricator
Differential D13803

[identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`
ClosedPublic
Actions

Authored by kamil on Tue, Oct 29, 7:47 AM.
Tags
None
Referenced Files
F3365946: D13803.id45421.diff
Mon, Nov 25, 8:36 AM
F3363290: D13803.id45421.diff
Mon, Nov 25, 1:29 AM
Unknown Object (File)
Sat, Nov 23, 3:17 AM
Unknown Object (File)
Mon, Nov 18, 3:24 PM
Unknown Object (File)
Mon, Nov 11, 4:06 AM
Unknown Object (File)
Mon, Nov 11, 1:03 AM
Unknown Object (File)
Sun, Nov 10, 1:25 PM
Unknown Object (File)
Sun, Nov 10, 1:03 AM
View All 29 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMaa69c9069ff7: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`
Summary

ENG-6145.

We'll need to use this on backup, to be able to call FindUserID RPC based on public user identifier - we need to somehow know if this is a Password or Wallet user

Test Plan

Run unit tests in Identity and comm-lib

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Tue, Oct 29, 7:47 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Oct 29, 7:47 AM
kamil added a child revision: D13805: [commtest] use registered `UserIdentity` in backup tests.Tue, Oct 29, 7:59 AM
Harbormaster failed remote builds in B32399: Diff 45421!Tue, Oct 29, 8:01 AM
kamil updated this revision to Diff 45424.Tue, Oct 29, 8:25 AM

CI

kamil updated this revision to Diff 45425.Tue, Oct 29, 8:33 AM

CI v2

Harbormaster failed remote builds in B32402: Diff 45424!Tue, Oct 29, 8:38 AM
Harbormaster completed remote builds in B32403: Diff 45425.Tue, Oct 29, 8:50 AM
kamil published this revision for review.Wed, Oct 30, 9:28 AM
varun accepted this revision.Wed, Oct 30, 10:18 AM
This revision is now accepted and ready to land.Wed, Oct 30, 10:18 AM
bartek accepted this revision.Mon, Nov 4, 4:56 AM
Closed by commit rCOMMaa69c9069ff7: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib` (authored by kamil). · Explain WhyThu, Nov 7, 4:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMaa69c9069ff7: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`.
kamil mentioned this in D13893: [terraform] deploy backup 0.5.0 to staging.Thu, Nov 7, 4:12 AM
kamil mentioned this in rCOMM4c2bf6a62dff: [terraform] deploy backup 0.5.0 to staging.Thu, Nov 7, 4:36 AM
kamil mentioned this in D13904: [terraform] deploy backup 0.5.0 to prod.Tue, Nov 12, 4:03 AM
kamil mentioned this in rCOMM54cc6a82a876: [terraform] deploy backup 0.5.0 to prod.Wed, Nov 13, 2:33 AM

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
services/
backup/
1 line
identity/
1 line
src/
7 lines
46 lines
shared/
comm-lib/
1 line
src/
crypto/
1 line
52 lines
web/
backup-client-wasm/

Diff 45660

View Options

Cargo.lock

Loading...
View Options

native/native_rust_library/Cargo.lock

Loading...
View Options

services/backup/Cargo.toml

Loading...
View Options

services/identity/Cargo.toml

Loading...
View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/siwe.rs

Loading...
View Options

shared/comm-lib/Cargo.toml

Loading...
View Options

shared/comm-lib/src/crypto/mod.rs

Loading...
View Options

shared/comm-lib/src/crypto/siwe.rs

Loading...
View Options

web/backup-client-wasm/Cargo.lock

Loading...