Page MenuHomePhabricator
Differential D13911

[lib] Convert sidebarInfoSelector to a hook
ClosedPublic
Actions

Authored by ashoat on Tue, Nov 12, 12:40 PM.
Tags
None
Referenced Files
F3333130: D13911.diff
Thu, Nov 21, 3:51 AM
F3328996: D13911.id45760.diff
Wed, Nov 20, 4:27 PM
F3325885: D13911.id45758.diff
Wed, Nov 20, 6:55 AM
F3325308: D13911.id.diff
Wed, Nov 20, 6:16 AM
Unknown Object (File)
Wed, Nov 20, 2:21 AM
Unknown Object (File)
Wed, Nov 20, 1:14 AM
Unknown Object (File)
Tue, Nov 19, 11:28 PM
Unknown Object (File)
Tue, Nov 19, 3:07 AM
View All 24 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMM0612ebfa0ff2: [lib] Convert sidebarInfoSelector to a hook
Summary

This will make a following diff a little easier.

Depends on D13921

Test Plan

Flow. Also tested in combination with the rest of the stack

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Tue, Nov 12, 12:40 PM
ashoat added a child revision: D13912: [lib] Extract getLastUpdatedTime to a separate file.
Harbormaster completed remote builds in B32622: Diff 45758.Tue, Nov 12, 1:06 PM
ashoat requested review of this revision.Tue, Nov 12, 1:06 PM
ashoat edited the summary of this revision. (Show Details)Tue, Nov 12, 2:48 PM
ashoat added a parent revision: D13921: [lib] Move sidebarInfoSelector to different folder.
ashoat removed a parent revision: D13910: [lib] Inline getMostRecentMessageInfo.
ashoat updated this revision to Diff 45781.Tue, Nov 12, 2:49 PM
ashoat edited the summary of this revision. (Show Details)
ashoat added a parent revision: D13910: [lib] Inline getMostRecentMessageInfo.

Rebase

ashoat edited the summary of this revision. (Show Details)Tue, Nov 12, 2:50 PM
ashoat edited the summary of this revision. (Show Details)
ashoat edited the summary of this revision. (Show Details)
ashoat removed a parent revision: D13910: [lib] Inline getMostRecentMessageInfo.
Harbormaster completed remote builds in B32643: Diff 45781.Tue, Nov 12, 3:48 PM
tomek accepted this revision.Wed, Nov 13, 3:37 AM
This revision is now accepted and ready to land.Wed, Nov 13, 3:37 AM
Closed by commit rCOMM0612ebfa0ff2: [lib] Convert sidebarInfoSelector to a hook (authored by ashoat). · Explain WhyWed, Nov 13, 11:20 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM0612ebfa0ff2: [lib] Convert sidebarInfoSelector to a hook.

Revision Contents
Changeset List

PathSize
lib/
hooks/
10 lines
72 lines
selectors/
4 lines

Diff 45781

View Options

lib/hooks/search-threads.js

Loading...
View Options

lib/hooks/sidebar-hooks.js

Loading...
View Options

lib/selectors/chat-selectors.js

Loading...