Details

Reviewers

Commits

rCOMM4e0a82f6329e: [Flow262][skip-ci] Remove %checks

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

v0.248.0: Support for long deprecated predicate function (%checks) is removed. It will still parse, but all of them will error with unsupported-syntax, and %checks will be completely ignored for type checking purpose as if it doesn't exist.

Replaced with type guards in D15039, D15065

Depends on D15026

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 22 2025, 2:25 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 22 2025, 2:25 AM

Skip ci

angelika retitled this revision from [Flow262] Remove %checks to [Flow262][skip-ci] Remove %checks.Jul 22 2025, 2:26 AM

angelika added a child revision: D15028: [Flow262][skip-ci] Add Partial to gesture events in useAnimatedGestureHandler.Jul 22 2025, 2:29 AM

Harbormaster failed remote builds in B34678: Diff 48877!Jul 22 2025, 2:39 AM

Harbormaster failed remote builds in B34679: Diff 48878!

angelika mentioned this in D15039: [Flow262][skip-ci] Add type guard to isIdentityDeviceType.Jul 22 2025, 8:42 PM

angelika mentioned this in D15065: [Flow262][skip-ci] Add isValidRawSidebarSourceMessageInfo()/isValidSidebarSourceMessageInfo().Jul 23 2025, 9:07 AM

Rebase

Harbormaster completed remote builds in B34874: Diff 49081.Jul 24 2025, 4:24 PM

angelika published this revision for review.Jul 25 2025, 9:32 AM

angelika added a reviewer: tomek.

angelika edited the summary of this revision. (Show Details)

tomek accepted this revision.Jul 29 2025, 3:45 PM

This revision is now accepted and ready to land.Jul 29 2025, 3:45 PM

Rebase & review changes

Harbormaster completed remote builds in B35141: Diff 49392.Aug 9 2025, 12:23 PM

Rebase & review changes

Harbormaster completed remote builds in B35407: Diff 49696.Aug 21 2025, 12:45 PM

Closed by commit rCOMM4e0a82f6329e: [Flow262][skip-ci] Remove %checks. · Explain WhyAug 21 2025, 7:32 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM4e0a82f6329e: [Flow262][skip-ci] Remove %checks.

angelika mentioned this in rCOMM509c07d91111: [Flow262][skip-ci] Add type guard to isIdentityDeviceType.

angelika mentioned this in rCOMM07bb083bac86: [Flow262][skip-ci] Add isValidRawSidebarSourceMessageInfo….

[Flow262][skip-ci] Remove %checks
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49696

lib/shared/message-utils.js

lib/types/identity-service-types.js

[Flow262][skip-ci] Remove %checksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49696

lib/shared/message-utils.js

lib/types/identity-service-types.js

[Flow262][skip-ci] Remove %checks
ClosedPublic
Actions

Revision Contents
Changeset List