Paths

Table of Contentst

Differential D15035

[Flow262][skip-ci] Fix tNumEnum
ClosedPublic
Actions

Authored by angelika on Jul 22 2025, 8:16 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM14279ac6c25e: [Flow262][skip-ci] Fix tNumEnum

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

Similar to D15021, flow now is more strict on numbers vs unions

Depends on D15034

Test Plan

Flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 22 2025, 8:16 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 22 2025, 8:16 PM

angelika added a child revision: D15036: [Flow262][skip-ci] Update types from native/types/react-native.js.Jul 22 2025, 8:18 PM

Harbormaster completed remote builds in B34689: Diff 48893.Jul 22 2025, 8:18 PM

Rebase

Harbormaster completed remote builds in B34880: Diff 49087.Jul 24 2025, 4:24 PM

angelika published this revision for review.Jul 25 2025, 9:35 AM

angelika added a reviewer: tomek.

tomek requested changes to this revision.Jul 30 2025, 4:36 PM

tomek added inline comments.

lib/types/thread-types-enum.js
95 ↗	(On Diff #49087)	A couple of lines earlier, we're defining `type ThinThreadType = $Values<typeof thinThreadTypes>;`.
110 ↗	(On Diff #49087)	Can we use `ThickThreadType`?

This revision now requires changes to proceed.Jul 30 2025, 4:36 PM

Rebase & review changes

Harbormaster completed remote builds in B35147: Diff 49398.Aug 9 2025, 12:24 PM

tomek requested changes to this revision.Aug 11 2025, 1:43 PM

tomek added inline comments.

lib/types/thread-types-enum.js
135–136	Isn't it just `ThreadType`?

This revision now requires changes to proceed.Aug 11 2025, 1:43 PM

Review changes

Harbormaster completed remote builds in B35270: Diff 49536.Aug 13 2025, 10:13 AM

tomek accepted this revision.Aug 13 2025, 1:55 PM

This revision is now accepted and ready to land.Aug 13 2025, 1:55 PM

Rebase & review changes

Harbormaster completed remote builds in B35413: Diff 49702.Aug 21 2025, 12:47 PM

Closed by commit rCOMM14279ac6c25e: [Flow262][skip-ci] Fix tNumEnum. · Explain WhyAug 21 2025, 7:32 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM14279ac6c25e: [Flow262][skip-ci] Fix tNumEnum.

Revision Contents
Changeset List

Path

Size

lib/

permissions/

special-roles.js

2 lines

types/

relationship-types.js

5 lines

thread-types-enum.js

8 lines

utils/

validation-utils.js

9 lines

Diff 49398

lib/permissions/special-roles.js

Loading...

lib/types/relationship-types.js

Loading...

lib/types/thread-types-enum.js

Loading...

lib/utils/validation-utils.js

Loading...