Details

Reviewers

Commits

rCOMM197dd0b3cab7: [Flow262][skip-ci] React.Element -> React.Node/React.MixedElement

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

React.Element was removed in flow 0.245.0. According to docs: https://flow.org/en/docs/react/types/#toc-react-element it should be replaced with
React.MixedElement or React.Node.

But it looks like cloneElement still takes React.Element https://github.com/facebook/flow/blob/6712ab6ac50f820f66669b1d71a767fd340c919c/lib/react.js#L163
so I silenced the error.

Also MixedElement doesn't have props property and we still use it, so I silenced the error by converting to any. Accessing props property on children looks like a hack to me anyway.

Depends on D15036

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 22 2025, 8:39 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 22 2025, 8:39 PM

angelika added a child revision: D15038: [Flow262][skip-ci] Update MeasureOnSuccessCallback import.Jul 22 2025, 8:40 PM

Harbormaster completed remote builds in B34691: Diff 48895.Jul 22 2025, 8:43 PM

Rebase

Harbormaster completed remote builds in B34882: Diff 49089.Jul 24 2025, 4:24 PM

angelika published this revision for review.Jul 25 2025, 9:36 AM

angelika added a reviewer: tomek.

It is a good idea to do more research here. It shouldn't be necessary to use any for a regular use case. Also, replacing Element with Node looks really wrong. Not sure if relevant, but in the docs there's something about https://flow.org/en/docs/react/render-types/ which might be useful.

lib/shared/markdown.js
48 ↗	(On Diff #49089)	This looks really wrong.

This revision now requires changes to proceed.Jul 30 2025, 5:01 PM

In D15037#416126, @tomek wrote:

It shouldn't be necessary to use any for a regular use case.

I'd say it's not a regular use case. Maybe it was years ago, now cloneElement is under "Legacy React APIs", the docs says Using cloneElement is uncommon and can lead to fragile code. and as for accessing props of children this is the first time I've seen this
react-native also silences errors on cloneElement for example here or here
as for accessing props on children they also silence errors for example here or here

Rebase & review changes

Harbormaster completed remote builds in B35149: Diff 49400.Aug 9 2025, 12:24 PM

This is reasonable, but quite fragile. I think there's an easy solution where we replace children with e.g. an array of objects and accept it as a prop or a custom children prop. So e.g. NavigationPanelContainer could accept a prop with Array<{tab: string, node: React.Node}> and render them in a loop.

lib/shared/markdown.js
49 ↗	(On Diff #49400)	Why do we replace this? `React.Node` is still a valid type, right?

This revision now requires changes to proceed.Aug 11 2025, 2:08 PM

Review changes

Refactored NavigationPanelContainer and SwipeSnake components.

Harbormaster completed remote builds in B35271: Diff 49537.Aug 13 2025, 10:14 AM

tomek requested changes to this revision.Aug 13 2025, 2:06 PM

tomek added inline comments.

web/navigation-panels/navigation-panel.react.js
54	It is critical that we memoize context values

This revision now requires changes to proceed.Aug 13 2025, 2:06 PM

Nice solutions to these problems!

Add memo

Harbormaster completed remote builds in B35305: Diff 49578.Aug 18 2025, 1:46 PM

tomek accepted this revision.Aug 18 2025, 1:54 PM

This revision is now accepted and ready to land.Aug 18 2025, 1:54 PM

Rebase & review changes

Harbormaster completed remote builds in B35415: Diff 49704.Aug 21 2025, 12:47 PM

Closed by commit rCOMM197dd0b3cab7: [Flow262][skip-ci] React.Element -> React.Node/React.MixedElement. · Explain WhyAug 21 2025, 7:32 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM197dd0b3cab7: [Flow262][skip-ci] React.Element -> React.Node/React.MixedElement.

[Flow262][skip-ci] React.Element -> React.Node/React.MixedElement
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49537

lib/shared/markdown.js

native/account/logged-out-modal.react.js

native/calendar/entry.react.js

native/chat/inline-engagement.react.js

native/chat/inner-robotext-message.react.js

native/chat/inner-text-message.react.js

native/chat/swipeable-message.react.js

native/components/node-height-measurer.react.js

web/navigation-panels/navigation-panel.react.js

[Flow262][skip-ci] React.Element -> React.Node/React.MixedElementClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49537

lib/shared/markdown.js

native/account/logged-out-modal.react.js

native/calendar/entry.react.js

native/chat/inline-engagement.react.js

native/chat/inner-robotext-message.react.js

native/chat/inner-text-message.react.js

native/chat/swipeable-message.react.js

native/components/node-height-measurer.react.js

web/navigation-panels/navigation-panel.react.js

[Flow262][skip-ci] React.Element -> React.Node/React.MixedElement
ClosedPublic
Actions

Revision Contents
Changeset List