Paths

Table of Contentst

Differential D15040

[Flow262][skip-ci] Fix errors in change-thread-settings-spec.js
ClosedPublic
Actions

Authored by angelika on Jul 22 2025, 10:02 PM.

Tags

None

Referenced Files

	F32159841: D15040.1765039158.diff
	Fri, Dec 5, 4:39 PM

Subscribers

Details

Reviewers

Commits

rCOMM6b4e4488289b: [Flow262][skip-ci] Fix errors in change-thread-settings-spec.js

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

Depends on D15039

Test Plan

Flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 22 2025, 10:02 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 22 2025, 10:02 PM

angelika added a child revision: D15041: [Flow262][skip-ci] Fix getNeynarURL.Jul 22 2025, 10:03 PM

Harbormaster failed remote builds in B34694: Diff 48898!Jul 22 2025, 10:15 PM

angelika retitled this revision from [Flow262] Fix errors in change-thread-settings-spec.js to [Flow262][skip-ci] Fix errors in change-thread-settings-spec.js.Jul 24 2025, 3:38 PM

Rebase

Harbormaster completed remote builds in B34885: Diff 49092.Jul 24 2025, 4:24 PM

angelika published this revision for review.Jul 25 2025, 9:37 AM

angelika added a reviewer: tomek.

tomek accepted this revision.Jul 30 2025, 5:11 PM

tomek added inline comments.

lib/shared/dm-ops/change-thread-settings-spec.js
74–77 ↗	(On Diff #49092)	We probably should wrap it with $ReadOnly, or make `avatar` mutable. In this type all the props but avatar are mutable, which is inconsistent

This revision is now accepted and ready to land.Jul 30 2025, 5:11 PM

Rebase & review changes

Harbormaster completed remote builds in B35152: Diff 49403.Aug 9 2025, 12:24 PM

Rebase & review changes

Harbormaster completed remote builds in B35418: Diff 49707.Aug 21 2025, 12:47 PM

Closed by commit rCOMM6b4e4488289b: [Flow262][skip-ci] Fix errors in change-thread-settings-spec.js. · Explain WhyAug 21 2025, 7:32 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM6b4e4488289b: [Flow262][skip-ci] Fix errors in change-thread-settings-spec.js.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

change-thread-settings-spec.js

15 lines

Diff 48898

lib/shared/dm-ops/change-thread-settings-spec.js

Loading...