Details
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/chat/chat-tab-bar.react.js | ||
|---|---|---|
| 39 | ButtonTitleToTip is an object with 2 keys that are literals. props.route.name is just a string so flow doesn't know if we can safely do this. | |
| native/chat/chat-tab-bar.react.js | ||
|---|---|---|
| 39 | Can we do it more safely, e.g. check if it is of the correct type? | |
| native/flow-typed/npm/@react-navigation/core_v6.x.x.js | ||
| 2290–2295 ↗ | (On Diff #49109) | How does this behave in terms of mutability? |
| native/navigation/chat-tab-bar-button.react.js | ||
| 42 ↗ | (On Diff #49109) | Are you sure we can safely remove void here? |
| native/chat/chat-tab-bar.react.js | ||
|---|---|---|
| 39 | We can but a line lower you have a check if tipType is defined anyway. | |
| native/flow-typed/npm/@react-navigation/core_v6.x.x.js | ||
| 2290–2295 ↗ | (On Diff #49109) | Do you mean there were + signs before and now there aren't and maybe we changed the mutability? |
| native/navigation/chat-tab-bar-button.react.js | ||
| 42 ↗ | (On Diff #49109) | We can't put void here because of ComponentType definition: declare export type ComponentType<-P: {...}> = component(...P)P can't be void because it has to extend {...}. |
| native/navigation/chat-tab-bar-button.react.js | ||
|---|---|---|
| 42 ↗ | (On Diff #49109) | Not sure... maybe the intention was to express some type of optionality? But in the case of the return type, removing it sounds safe. |