Paths

Table of Contentst

Differential D15062

[Flow262][skip-ci] SyntheticEvent fixes
ClosedPublic
Actions

Authored by angelika on Jul 23 2025, 8:56 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM086256ecca6d: [Flow262][skip-ci] SyntheticEvent fixes

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

Depends on D15061

Test Plan

Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jul 23 2025, 8:56 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 23 2025, 8:56 AM

Harbormaster completed remote builds in B34718: Diff 48922.Jul 23 2025, 8:58 AM

angelika added a child revision: D15063: [Flow262][skip-ci] Fix Dispatch type.Jul 23 2025, 8:59 AM

Rebase

Harbormaster completed remote builds in B34907: Diff 49114.Jul 24 2025, 4:26 PM

angelika published this revision for review.Jul 25 2025, 9:45 AM

angelika added a reviewer: tomek.

tomek accepted this revision.Jul 31 2025, 1:59 PM

tomek added inline comments.

web/chat/chat-input-bar.react.js
474–477 ↗	(On Diff #49114)	Not sure if we ever reach this `else`. If the key is `Enter`, then the `action` is defined and we're inside `if`.

This revision is now accepted and ready to land.Jul 31 2025, 1:59 PM

Rebase & review changes

Harbormaster completed remote builds in B35173: Diff 49424.Aug 9 2025, 12:28 PM

angelika added inline comments.Aug 21 2025, 8:39 AM

web/chat/chat-input-bar.react.js
474–477 ↗	(On Diff #49114)	it could be that `this.props.inputState.typeaheadState.canBeVisible = false` and action is definied and `eventKey === 'Enter'` then we won't hit if and we'll hit else

Rebase & review changes

Harbormaster completed remote builds in B35439: Diff 49728.Aug 21 2025, 12:51 PM

Closed by commit rCOMM086256ecca6d: [Flow262][skip-ci] SyntheticEvent fixes. · Explain WhyAug 21 2025, 7:33 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM086256ecca6d: [Flow262][skip-ci] SyntheticEvent fixes.

Revision Contents
Changeset List

Path

Size

landing/

subscription-form.react.js

2 lines

web/

chat/

chat-input-bar.react.js

17 lines

sidebar/

community-picker.react.js

2 lines

Diff 49906

landing/subscription-form.react.js

Loading...

web/chat/chat-input-bar.react.js

Loading...

web/sidebar/community-picker.react.js

Loading...