Paths

Table of Contentst

Differential D15079

[Flow262][skip-ci] Fix: unreadCount can be undefined
ClosedPublic
Actions

Authored by angelika on Jul 23 2025, 9:52 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMa8be73228f40: [Flow262][skip-ci] Fix: unreadCount can be undefined

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

Depends on D15078

Test Plan

Flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 23 2025, 9:52 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 23 2025, 9:52 AM

angelika added a child revision: D15080: [Flow262][skip-ci] Remove invalid type from reduceAlertStore.Jul 23 2025, 9:54 AM

Harbormaster completed remote builds in B34735: Diff 48939.Jul 23 2025, 9:55 AM

Rebase

Harbormaster completed remote builds in B34924: Diff 49131.Jul 24 2025, 4:28 PM

angelika published this revision for review.Jul 25 2025, 9:51 AM

angelika added a reviewer: tomek.

tomek requested changes to this revision.Jul 31 2025, 2:50 PM

tomek added inline comments.

web/push-notif/notif-crypto-utils.js
445–447 ↗	(On Diff #49131)	We should analyze it a bit. What happens if this function is called with `undefined`? How is this value used later? Does `undefined` have a special meaning there? Do we set it to `undefined` on purpose?

This revision now requires changes to proceed.Jul 31 2025, 2:50 PM

Rebase & review changes

Harbormaster completed remote builds in B35189: Diff 49440.Aug 9 2025, 12:31 PM

tomek accepted this revision.Aug 11 2025, 3:17 PM

This revision is now accepted and ready to land.Aug 11 2025, 3:17 PM

Rebase & review changes

Harbormaster completed remote builds in B35455: Diff 49744.Aug 21 2025, 12:53 PM

Closed by commit rCOMMa8be73228f40: [Flow262][skip-ci] Fix: unreadCount can be undefined. · Explain WhyAug 21 2025, 7:33 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMa8be73228f40: [Flow262][skip-ci] Fix: unreadCount can be undefined.

Revision Contents
Changeset List

Path

Size

web/

push-notif/

notif-crypto-utils.js

18 lines

Diff 49440

web/push-notif/notif-crypto-utils.js

Loading...