Details

Reviewers

tomek

Commits

rCOMM3e033eac1ca4: [Flow269][skip-ci] Migrate from $Diff

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

v0.268.0: $Diff support is removed.
They provided a polyfill but it's not working well. Omit type works better.

Depends on D15109

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 24 2025, 7:43 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2025, 7:43 AM

Harbormaster completed remote builds in B34769: Diff 48974.Jul 24 2025, 7:45 AM

angelika added a child revision: D15111: [Flow269][skip-ci] Migrate React.memo.Jul 24 2025, 7:47 AM

Rebase

Harbormaster completed remote builds in B34953: Diff 49160.Jul 24 2025, 4:32 PM

angelika published this revision for review.Jul 25 2025, 10:00 AM

angelika added a reviewer: tomek.

tomek accepted this revision.Aug 4 2025, 3:39 PM

tomek added inline comments.

native/components/tag-input.react.js
453–454 ↗	(On Diff #49160)	Can we use the consistent type here? Either `typeof BaseTagInput.defaultProps` or `DefaultProps` in both places

This revision is now accepted and ready to land.Aug 4 2025, 3:39 PM

Rebase & review changes

Harbormaster completed remote builds in B35218: Diff 49469.Aug 9 2025, 12:36 PM

angelika mentioned this in D15043: [Flow262][skip-ci] Replace React.Config.Aug 11 2025, 11:48 AM

Fix

Harbormaster completed remote builds in B35253: Diff 49510.Aug 11 2025, 1:01 PM

Rebase & review changes

Harbormaster completed remote builds in B35484: Diff 49773.Aug 21 2025, 12:58 PM

Closed by commit rCOMM3e033eac1ca4: [Flow269][skip-ci] Migrate from $Diff. · Explain WhyAug 21 2025, 7:34 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM3e033eac1ca4: [Flow269][skip-ci] Migrate from $Diff.

[Flow269][skip-ci] Migrate from $Diff
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49469

lib/components/base-auto-join-community-handler.react.js

lib/keyserver-conn/keyserver-connections-handler.js

lib/ops/keyserver-store-ops.js

lib/shared/transforms/keyserver-store-transform.js

lib/types/minimally-encoded-thread-permissions-types.js

lib/types/socket-types.js

native/components/tag-input.react.js

native/flow-typed/npm/@react-navigation/core_v6.x.x.js

native/redux/persist.js

native/types/styles.js

web/flow-typed/npm/react-color_v2.x.x.js

web/flow-typed/npm/react-hot-loader_v4.6.x.js

web/flow-typed/npm/react-router-dom_v5.x.x.js

[Flow269][skip-ci] Migrate from $DiffClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49469

lib/components/base-auto-join-community-handler.react.js

lib/keyserver-conn/keyserver-connections-handler.js

lib/ops/keyserver-store-ops.js

lib/shared/transforms/keyserver-store-transform.js

lib/types/minimally-encoded-thread-permissions-types.js

lib/types/socket-types.js

native/components/tag-input.react.js

native/flow-typed/npm/@react-navigation/core_v6.x.x.js

native/redux/persist.js

native/types/styles.js

web/flow-typed/npm/react-color_v2.x.x.js

web/flow-typed/npm/react-hot-loader_v4.6.x.js

web/flow-typed/npm/react-router-dom_v5.x.x.js

[Flow269][skip-ci] Migrate from $Diff
ClosedPublic
Actions

Revision Contents
Changeset List