Page MenuHomePhabricator

[web] Displaying 'Edit' label next to edited messages
ClosedPublic

Authored by kuba on Mar 9 2023, 3:42 AM.
Tags
None
Referenced Files
F3373619: D7018.diff
Tue, Nov 26, 10:37 AM
Unknown Object (File)
Sun, Nov 10, 4:41 PM
Unknown Object (File)
Sun, Nov 10, 3:02 PM
Unknown Object (File)
Sun, Nov 10, 12:20 PM
Unknown Object (File)
Sun, Nov 10, 9:15 AM
Unknown Object (File)
Oct 21 2024, 2:04 AM
Unknown Object (File)
Oct 20 2024, 11:08 AM
Unknown Object (File)
Oct 20 2024, 11:08 AM
Subscribers

Details

Summary

Added displaying 'Edit' label next to edited messages.

Test Plan

Tested displaying on both sides (left and right) with:

  1. message not edited and without thread/reactions,
  2. message edited without thread/reactions,
  3. message not edited with thread/reactions,
  4. message edited with thread,
  5. message edited with reactions,
  6. message edited with thread and reactions,
  7. many edited messages in a row,

Screenshots:
[1, 2, 3, 5, 6]

Screenshot 2023-03-09 at 12.41.13.png (1×1 px, 149 KB)

[4]
Screenshot 2023-03-09 at 12.46.39.png (188×264 px, 11 KB)

[7]
Screenshot 2023-03-09 at 12.41.56.png (746×648 px, 54 KB)

Diff Detail

Repository
rCOMM Comm
Branch
kuba/messageediting
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Ah nice, disregard my comment about the if condition in the previous diff.

This revision is now accepted and ready to land.Mar 16 2023, 6:50 PM