Differential D7415

[lib] Change definition of useEditMessage function
ClosedPublic
Actions

Authored by • kuba on Apr 13 2023, 4:27 AM.

Tags

None

Referenced Files

	F2832886: D7415.id25668.diff
	Sat, Sep 28, 6:29 AM

	F2832885: D7415.id25093.diff
	Sat, Sep 28, 6:29 AM

	F2832862: D7415.id.diff
	Sat, Sep 28, 6:29 AM

	F2832846: D7415.diff
	Sat, Sep 28, 6:22 AM

	Unknown Object (File)
	Sat, Sep 14, 2:54 PM

	Unknown Object (File)
	Aug 26 2024, 5:37 PM

	Unknown Object (File)
	Aug 26 2024, 2:50 PM

	Unknown Object (File)
	Aug 25 2024, 2:21 PM

View All 63 Files

Subscribers

Details

Reviewers

michal
inka
ginsu

Commits

rCOMM90b1e32fd73a: [lib] Change definition of useEditMessage function

Summary

Moved messageID argument from useEditMessage to the function that it returns.

Test Plan

It is used in next diff to edit the message on native. Here only tested if the app still works.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.Apr 13 2023, 4:27 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 13 2023, 4:27 AM

• kuba added a parent revision: D7349: [native] Add alert when exiting edit mode by clicking the exit button.Apr 13 2023, 4:27 AM

Harbormaster completed remote builds in B18315: Diff 25093.Apr 13 2023, 4:43 AM

• kuba requested review of this revision.Apr 13 2023, 4:43 AM

• kuba added a child revision: D7445: [native] Added message editing.Apr 14 2023, 1:20 AM

michal accepted this revision.Apr 17 2023, 2:16 AM

This revision is now accepted and ready to land.Apr 17 2023, 2:16 AM

Closed by commit rCOMM90b1e32fd73a: [lib] Change definition of useEditMessage function (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyApr 25 2023, 6:44 AM

This revision was automatically updated to reflect the committed changes.

kosmydel <kukubaczek@gmail.com> added a commit: rCOMM90b1e32fd73a: [lib] Change definition of useEditMessage function.

Revision Contents
Changeset List

Path

Size

lib/

shared/

edit-messages-utils.js

9 lines

Diff 25093

lib/shared/edit-messages-utils.js

Loading...