Page MenuHomePhabricator
Differential D7535

[identity] fix numbering issues in proto file
ClosedPublic
Actions

Authored by varun on Apr 19 2023, 1:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 1:50 AM
Unknown Object (File)
Mon, Mar 3, 1:50 AM
Unknown Object (File)
Mon, Mar 3, 1:50 AM
Unknown Object (File)
Mon, Mar 3, 1:50 AM
Unknown Object (File)
Mon, Mar 3, 1:50 AM
Unknown Object (File)
Sat, Mar 1, 3:27 PM
Unknown Object (File)
Feb 28 2025, 1:30 AM
Unknown Object (File)
Feb 24 2025, 12:04 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
Commits
rCOMMb82db410cba3: [identity] fix numbering issues in proto file
Summary

small changes, just noticed some issues with numbering

Depends on D7534

Test Plan

no issues building the service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Apr 19 2023, 1:11 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 1:11 PM
varun added a child revision: D7536: [identity] manage login state.Apr 19 2023, 1:12 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:24 PM
Harbormaster failed remote builds in B18535: Diff 25399!
varun updated this revision to Diff 25416.Apr 19 2023, 2:19 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:31 PM
Harbormaster failed remote builds in B18551: Diff 25416!
varun updated this revision to Diff 25460.Apr 20 2023, 10:13 AM

rebase

Harbormaster completed remote builds in B18584: Diff 25460.Apr 20 2023, 10:32 AM
varun requested review of this revision.Apr 20 2023, 10:32 AM
• jon accepted this revision.Apr 20 2023, 10:53 AM
This revision is now accepted and ready to land.Apr 20 2023, 10:53 AM
Closed by commit rCOMMb82db410cba3: [identity] fix numbering issues in proto file (authored by varun). · Explain WhyApr 21 2023, 11:40 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMb82db410cba3: [identity] fix numbering issues in proto file.

Revision Contents
Changeset List

PathSize
shared/
protos/
8 lines

Diff 25416

View Options

shared/protos/identity_client.proto

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Linesimport {
logInResponder, logInResponder,
siweAuthResponder, siweAuthResponder,
oldPasswordUpdateResponder, oldPasswordUpdateResponder,
updateUserSettingsResponder, updateUserSettingsResponder,
policyAcknowledgmentResponder, policyAcknowledgmentResponder,
updateUserAvatarResponder, updateUserAvatarResponder,
} from './responders/user-responders.js'; } from './responders/user-responders.js';
import { codeVerificationResponder } from './responders/verification-responders.js'; import { codeVerificationResponder } from './responders/verification-responders.js';
import { versionResponder } from './responders/version-responders.js';
import { import {
uploadMediaMetadataResponder, uploadMediaMetadataResponder,
uploadDeletionResponder, uploadDeletionResponder,
} from './uploads/uploads.js'; } from './uploads/uploads.js';
const jsonEndpoints: { [id: Endpoint]: JSONResponder } = { const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
create_account: { create_account: {
responder: accountCreationResponder, responder: accountCreationResponder,
▲ Show 20 Lines • Show All 218 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: { get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder, responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [], requiredPolicies: [],
}, },
version: {
responder: versionResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };