Page MenuHomePhabricator
Differential D8267

[web] Add `ColorSelector` to `EmojiAvatarSelectionModal`
ClosedPublic
Actions

Authored by atul on Jun 20 2023, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 12:15 PM
Unknown Object (File)
Sun, Dec 15, 5:35 PM
Unknown Object (File)
Sat, Dec 14, 4:19 PM
Unknown Object (File)
Sat, Dec 14, 7:20 AM
Unknown Object (File)
Fri, Nov 29, 2:32 AM
Unknown Object (File)
Mon, Nov 25, 1:48 PM
Unknown Object (File)
Mon, Nov 25, 1:48 PM
Unknown Object (File)
Nov 23 2024, 1:08 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
michal
kamil
inka
rohan
Commits
rCOMM5814bc62eca6: [web] Add `ColorSelector` to `EmojiAvatarSelectionModal`
Summary

Add ColorSelector to EmojiAvatarSelectionModal and hook up to pendingAvatarColor.

Depends on D8266

Test Plan

Works as expected:

a4c4d1.png (710×738 px, 73 KB)

9a48f1.png (728×734 px, 74 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 20 2023, 2:08 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2023, 2:08 PM
atul published this revision for review.Jun 20 2023, 2:11 PM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B20369: Diff 27914.Jun 20 2023, 2:27 PM
atul added a child revision: D8268: [web] Add emoji `Picker` to `EmojiAvatarSelectionModal`.Jun 20 2023, 3:16 PM
atul added reviewers: michal, kamil, inka, rohan.Jun 21 2023, 9:46 AM
rohan accepted this revision.Jun 21 2023, 10:53 AM
This revision is now accepted and ready to land.Jun 21 2023, 10:53 AM
atul updated this revision to Diff 28024.Jun 22 2023, 2:07 PM

rebase before landing

Harbormaster failed remote builds in B20442: Diff 28024!Jun 22 2023, 2:35 PM
atul updated this revision to Diff 28073.Jun 23 2023, 1:35 PM

rebase before landing

Harbormaster completed remote builds in B20487: Diff 28073.Jun 23 2023, 1:53 PM
Closed by commit rCOMM5814bc62eca6: [web] Add `ColorSelector` to `EmojiAvatarSelectionModal` (authored by atul). · Explain WhyJun 23 2023, 2:07 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM5814bc62eca6: [web] Add `ColorSelector` to `EmojiAvatarSelectionModal`.

Revision Contents
Changeset List

PathSize
web/
avatars/
8 lines

Diff 28024

View Options

web/avatars/emoji-avatar-selection-modal.react.js

Loading...